netlink: fix casts
ClosedPublic
Actions

Authored by kp on Feb 26 2024, 6:46 PM.

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rG14bbf0943308: netlink: fix casts
rG48f33b55b014: netlink: fix casts

Summary

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56250
Build 53138: arc lint + arc unit

Event Timeline

kp created this revision.Feb 26 2024, 6:46 PM

Herald added a reviewer: melifaro. · View Herald TranscriptFeb 26 2024, 6:46 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

kp requested review of this revision.Feb 26 2024, 6:46 PM

Harbormaster completed remote builds in B56250: Diff 135020.Feb 26 2024, 6:46 PM

kp added a child revision: D44089: netlink: add bool type support.Feb 26 2024, 6:46 PM

melifaro accepted this revision.Feb 26 2024, 7:24 PM

This revision is now accepted and ready to land.Feb 26 2024, 7:24 PM

Will this be MFCed to stable branches ? I see sys/netlink/route/nexthop.c is consuming the fixed function nlattr_get_uint8():

sys/netlink/route/nexthop.c:	{ .type = NHAF_FAMILY, .off = _OUT(nhaf_family), .cb = nlattr_get_uint8 },

In D44088#1006073, @zlei wrote:
Will this be MFCed to stable branches ? I see sys/netlink/route/nexthop.c is consuming the fixed function nlattr_get_uint8():
sys/netlink/route/nexthop.c:	{ .type = NHAF_FAMILY, .off = _OUT(nhaf_family), .cb = nlattr_get_uint8 },

We probably should, although as far as I know this doesn't actually break anything. It's just something that caught my eye as I was looking at this code.

Closed by commit rG48f33b55b014: netlink: fix casts (authored by kp). · Explain WhyFeb 28 2024, 10:27 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG48f33b55b014: netlink: fix casts.

kp added a commit: rG14bbf0943308: netlink: fix casts.Mar 8 2024, 9:11 AM