Page MenuHomeFreeBSD
Differential D43764

x86/xen: implement early init hook
ClosedPublic
Actions

Authored by royger on Feb 6 2024, 8:42 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, Dec 3, 12:07 PM
Unknown Object (File)
Nov 25 2024, 11:03 PM
Unknown Object (File)
Nov 25 2024, 11:03 PM
Unknown Object (File)
Nov 25 2024, 11:03 PM
Unknown Object (File)
Nov 25 2024, 8:14 PM
Unknown Object (File)
Nov 25 2024, 3:48 PM
Unknown Object (File)
Nov 25 2024, 2:55 PM
Unknown Object (File)
Nov 24 2024, 1:49 PM
View All Files
Subscribers
ehem_freebsd_m5p.com
imp

Details

Reviewers
kib
cem
jhb
markj
Commits
rG8f5406c77f1b: x86/xen: implement early init hook
Summary

Unify the HVM and PVH early setup, byt making both rely on the hypervisor
initialization hook part of identify_hypervisor().

The current initialization takes care of the hypercall page, the sahred info
page and does any fixup necessary to metadata video console information if
FreeBSD is booted as the initial domain (so the video console is handed from
Xen into FreeBSD).

Note this has the nice side effect of also allowing to use the Xen console on
HVM guests, which allows to get rid of the QEMU emulated uart and still get
a nice text console.

Sponsored by: Cloud Software Group

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

royger created this revision.Feb 6 2024, 8:42 AM
Herald added subscribers: ehem_freebsd_m5p.com, imp. · View Herald TranscriptFeb 6 2024, 8:42 AM
royger requested review of this revision.Feb 6 2024, 8:42 AM
royger edited the summary of this revision. (Show Details)
markj added a comment.Feb 6 2024, 3:56 PM

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

royger added a comment.Feb 6 2024, 3:58 PM
In D43764#998144, @markj wrote:

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

Hm, that's the output from git format-patch. I wonder why it doesn't pick the context automatically from the repo?

markj added a comment.Feb 6 2024, 4:01 PM
In D43764#998147, @royger wrote:
In D43764#998144, @markj wrote:

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

Hm, that's the output from git format-patch. I wonder why it doesn't pick the context automatically from the repo?

How are you uploading it? arc diff --create <revision> or git arc create will indeed fetch context automatically. If you're manually uploading diffs, then it won't. See https://wiki.freebsd.org/Phabricator#Create_a_Revision

royger added a comment.Feb 6 2024, 4:16 PM
In D43764#998154, @markj wrote:
In D43764#998147, @royger wrote:
In D43764#998144, @markj wrote:

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

Hm, that's the output from git format-patch. I wonder why it doesn't pick the context automatically from the repo?

How are you uploading it? arc diff --create <revision> or git arc create will indeed fetch context automatically. If you're manually uploading diffs, then it won't. See https://wiki.freebsd.org/Phabricator#Create_a_Revision

I'm uploading manually, as getting arc setup is a pain.

royger updated this revision to Diff 133925.Feb 6 2024, 4:16 PM

Upload diff with context.

ehem_freebsd_m5p.com added a comment.Feb 6 2024, 7:54 PM

Guess I had it easy as I had a system running Linux and arcanist was available as a package.

I was hoping to check map_shared_info() since that is also needed on ARM.

sys/x86/xen/hvm.c
445

The implementation of map_shared_info() is missing from this diff.

royger added inline comments.Feb 6 2024, 8:02 PM
sys/x86/xen/hvm.c
445

It's in a previous patch:
https://xenbits.xen.org/gitweb/?p=people/royger/freebsd.git;a=commit;h=60e0dcd9044fa1cc6df659d6be4879b8a86411ef

markj added inline comments.Feb 11 2024, 3:35 PM
sys/x86/xen/hvm.c
281–283

Should this be hv_high < hv_base + 2?

445

Is there any reason not to put it in phabricator as well? It's harder to understand this diff without having read that one.

446

panic strings don't need newlines.

royger added inline comments.Feb 11 2024, 3:54 PM
sys/x86/xen/hvm.c
445

I would usually not get review for Xen specific patches, but can put the whole series on phab if there's interest.

royger updated this revision to Diff 134429.Feb 16 2024, 12:04 PM

Fix comments.

royger updated this revision to Diff 134442.Feb 16 2024, 12:44 PM

Context adjustments due to modifications in previous patches

markj accepted this revision.Feb 19 2024, 2:11 PM
This revision is now accepted and ready to land.Feb 19 2024, 2:11 PM
Closed by commit rG8f5406c77f1b: x86/xen: implement early init hook (authored by royger). · Explain WhyFeb 22 2024, 10:32 AM
This revision was automatically updated to reflect the committed changes.
royger added a commit: rG8f5406c77f1b: x86/xen: implement early init hook.

Revision Contents
Changeset List

PathSize
sys/
x86/
include/
xen/
2 lines
x86/
10 lines
xen/
105 lines
17 lines

Diff 134442

View Options

sys/x86/include/xen/xen-os.h

Loading...
View Options

sys/x86/x86/identcpu.c

Loading...
View Options

sys/x86/xen/hvm.c

Loading...
View Options

sys/x86/xen/pv.c

Loading...