Page MenuHomeFreeBSD
Differential D43532

bintrans: Error out if writing to the output failed.
ClosedPublic
Actions

Authored by des on Jan 21 2024, 5:37 PM.
Tags
None
Referenced Files
F174628789: D43532.id133511.diff
Sun, Oct 4, 7:10 PM
Unknown Object (File)
Sat, Oct 3, 11:13 AM
Unknown Object (File)
Fri, Oct 2, 6:33 PM
Unknown Object (File)
Fri, Oct 2, 5:15 PM
Unknown Object (File)
Fri, Oct 2, 4:07 PM
Unknown Object (File)
Wed, Sep 30, 8:23 PM
Unknown Object (File)
Mon, Sep 28, 7:15 PM
Unknown Object (File)
Sun, Sep 20, 4:57 PM
View All Files
Subscribers
allanjude
imp

Details

Reviewers
allanjude
Group Reviewers
Klara
Commits
rGfa778f0ce5ef: bintrans: Error out if writing to the output failed.
rG5cb28f797977: bintrans: Error out if writing to the output failed.
Summary
  • Cover all code paths.
  • When decoding, check all output files, not just the last one.
  • A simple ferror() check is not enough as an error may later occur while flushing whatever remains in the output buffer.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55691
Build 52580: arc lint + arc unit

Event Timeline

des created this revision.Jan 21 2024, 5:37 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 21 2024, 5:37 PM
des requested review of this revision.Jan 21 2024, 5:37 PM
Harbormaster completed remote builds in B55520: Diff 133115.Jan 21 2024, 5:37 PM
des added a child revision: D43533: bintrans: Avoid leaking a stack pointer through a global..Jan 21 2024, 5:37 PM
des added a comment.Jan 21 2024, 5:40 PM

This needs a little more work as base64_decode() may return early.

des updated this revision to Diff 133192.Jan 23 2024, 12:54 PM

fix decode cases correctly

Harbormaster completed remote builds in B55566: Diff 133192.Jan 23 2024, 12:55 PM
des removed a child revision: D43533: bintrans: Avoid leaking a stack pointer through a global..Jan 23 2024, 1:01 PM
des updated this revision to Diff 133511.Jan 29 2024, 6:09 PM

reset outfile too

Harbormaster completed remote builds in B55691: Diff 133511.Jan 29 2024, 6:09 PM
allanjude accepted this revision as: allanjude.Jan 31 2024, 2:40 PM
allanjude added a subscriber: allanjude.

Reviewed-by: allanjude

This revision is now accepted and ready to land.Jan 31 2024, 2:40 PM
Closed by commit rG5cb28f797977: bintrans: Error out if writing to the output failed. (authored by des). · Explain WhyFeb 1 2024, 1:11 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG5cb28f797977: bintrans: Error out if writing to the output failed..
des mentioned this in D43870: md5: Accept "-" as alias for stdin..Feb 14 2024, 2:02 PM
des added a commit: rGfa778f0ce5ef: bintrans: Error out if writing to the output failed..Feb 24 2024, 12:15 PM

Revision Contents
Changeset List

PathSize
usr.bin/
bintrans/
33 lines
4 lines

Diff 133511

View Options

usr.bin/bintrans/uudecode.c

Loading...
View Options

usr.bin/bintrans/uuencode.c

Loading...