Page MenuHomeFreeBSD

bintrans: Error out if writing to the output failed.
ClosedPublic

Authored by des on Jan 21 2024, 5:37 PM.
Tags
None
Referenced Files
F125044655: D43532.id.diff
Sat, Aug 2, 7:51 PM
Unknown Object (File)
Mon, Jul 28, 1:39 PM
Unknown Object (File)
Sat, Jul 26, 1:42 AM
Unknown Object (File)
Thu, Jul 24, 12:05 AM
Unknown Object (File)
Sat, Jul 19, 7:04 AM
Unknown Object (File)
Mon, Jul 14, 1:49 AM
Unknown Object (File)
Sun, Jul 6, 8:31 AM
Unknown Object (File)
Sat, Jul 5, 7:07 AM
Subscribers

Details

Summary
  • Cover all code paths.
  • When decoding, check all output files, not just the last one.
  • A simple ferror() check is not enough as an error may later occur while flushing whatever remains in the output buffer.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55566
Build 52455: arc lint + arc unit

Event Timeline

des requested review of this revision.Jan 21 2024, 5:37 PM

This needs a little more work as base64_decode() may return early.

fix decode cases correctly

allanjude added a subscriber: allanjude.

Reviewed-by: allanjude

This revision is now accepted and ready to land.Jan 31 2024, 2:40 PM