Page MenuHomeFreeBSD

bintrans: Error out if writing to the output failed.
ClosedPublic

Authored by des on Jan 21 2024, 5:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 12:45 PM
Unknown Object (File)
Mon, Jan 27, 5:02 PM
Unknown Object (File)
Mon, Jan 27, 4:45 PM
Unknown Object (File)
Mon, Jan 27, 4:39 PM
Unknown Object (File)
Sat, Jan 25, 7:37 PM
Unknown Object (File)
Thu, Jan 23, 7:17 PM
Unknown Object (File)
Thu, Jan 23, 6:23 PM
Unknown Object (File)
Thu, Jan 9, 2:11 AM
Subscribers

Details

Summary
  • Cover all code paths.
  • When decoding, check all output files, not just the last one.
  • A simple ferror() check is not enough as an error may later occur while flushing whatever remains in the output buffer.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55520
Build 52409: arc lint + arc unit

Event Timeline

des requested review of this revision.Jan 21 2024, 5:37 PM

This needs a little more work as base64_decode() may return early.

fix decode cases correctly

allanjude added a subscriber: allanjude.

Reviewed-by: allanjude

This revision is now accepted and ready to land.Jan 31 2024, 2:40 PM