Page MenuHomeFreeBSD
Differential D43648

LinuxKPI: 802.11: hardware crypto offload improvements
AbandonedPublic
Actions

Authored by bz on Jan 29 2024, 3:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 21, 4:35 AM
Unknown Object (File)
Thu, Aug 13, 12:30 PM
Unknown Object (File)
Tue, Aug 11, 4:27 PM
Unknown Object (File)
Sun, Aug 9, 1:34 PM
Unknown Object (File)
Sat, Aug 8, 10:21 PM
Unknown Object (File)
Sat, Aug 8, 5:34 PM
Unknown Object (File)
Fri, Aug 7, 5:36 PM
Unknown Object (File)
Fri, Aug 7, 2:54 PM
View All Files
Subscribers
emaste
imp
linuxkpi
wireless

Details

Reviewers
cc
adrian
Summary

Split _lkpi_iv_key_set_delete() up into set and delete versions as
they are called from net80211.

Add mappings of flags between LinuxKPI and net80211 so we can
take appropriate (non-)action in net80211.
There are more flags to map at a later point for other bits.
Will will also need sort out the one which doesn't map 1:1.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 55680
Build 52569: arc lint + arc unit

Event Timeline

bz created this revision.Jan 29 2024, 3:11 PM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptJan 29 2024, 3:11 PM
bz requested review of this revision.Jan 29 2024, 3:11 PM
Harbormaster completed remote builds in B55680: Diff 133497.Jan 29 2024, 3:12 PM
bz added parent revisions: D43634: net80211: crypto: fix check for driver having done decryption, D43635: LinuxKPI: 802.11: fix field order in ieee80211_key_conf.Jan 29 2024, 3:13 PM
bz added a comment.Jan 29 2024, 7:59 PM

I cannot actually request changes on my own review. Sad.

sys/compat/linuxkpi/common/src/linux_80211.c
701

It's amazing that -DKERNFAST builds did somehow build this before but cmd is no longer set in either function; I'll fix that.

bz updated this revision to Diff 133529.Jan 29 2024, 8:21 PM

cmd was gone, replace with defined values.

Harbormaster completed remote builds in B55694: Diff 133529.Jan 29 2024, 8:21 PM
bz planned changes to this revision.Jan 29 2024, 11:22 PM

Ok, Probably too tired last night. I'll keep updating this... Watch this space.

bz mentioned this in D43945: LinuxKPI w/ LKPI_80211_HW_CRYPTO: fix non-sleepable mutex use..Feb 19 2024, 6:40 PM
cc requested changes to this revision.Feb 26 2024, 8:58 PM

Please add PR: 277095 in the summary, as this patch also fixes that.

sys/compat/linuxkpi/common/src/linux_80211.c
693

Instead of D80211_TRACE, suggest a dedicated trace flag for LinuxKPI, like this:

D80211_TRACE_CRYPTO
762–765

Why don't you free lsta->kc directly? like this:

	free(lsta->kc, M_LKPI80211);
	lsta->kc = NULL;
768–769

Adjust alignment like this:

	lcipher = lkpi_net80211_to_l80211_cipher_suite(k->wk_cipher->ic_cipher,
						       k->wk_keylen);
770–774

Currently duplicating with the switch (kc->cipher) code below. As return (0) is added here, suggest remove the switch (kc->cipher) code below and add the case WLAN_CIPHER_SUITE_CCMP: code here. like this:

	switch (lcipher) {
	case WLAN_CIPHER_SUITE_CCMP:
		kc->iv_len = k->wk_cipher->ic_header;
		kc->icv_len = k->wk_cipher->ic_trailer;
		break;
	case WLAN_CIPHER_SUITE_TKIP:
790–800

Remove this chunk as reasoned above.

cc added inline comments.Mar 6 2024, 7:48 PM
sys/compat/linuxkpi/common/src/linux_80211.c
760–765

I found a problem of this lsta->kc free when a "AES-CCM keyix 1 flags 0x106 on mac ff:ff:ff:ff:ff:ff" is set. As a result, there seems to be a deadloop of setting "keyix 0" and "keyix 1".

I will send you my private prints in email.

bz added inline comments.Mar 6 2024, 7:56 PM
sys/compat/linuxkpi/common/src/linux_80211.c
760–765

Yes, see the discussion in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277095 ; if you are still testing this version as-is three weeks later I am not surprised you are still finding problems.

cc added inline comments.Mar 6 2024, 8:35 PM
sys/compat/linuxkpi/common/src/linux_80211.c
760–765

Thanks for confirming. I am wondering that, but don't know/unclear about the priorities after these many patches in review. I will followup with https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277095#c2, and make the progress on top of this patch.

By the way, are you going to update D43634 based on the comment and then need my review again? The update shall not delay you much time.

cc mentioned this in D43634: net80211: crypto: fix check for driver having done decryption.Mar 15 2024, 6:30 PM
cc mentioned this in D44463: LinuxKPI: LKPI_80211_HW_CRYPTO: add basic multi-keys support.Mar 21 2024, 10:11 PM
bz abandoned this revision.Dec 31 2024, 1:36 PM

This was never finished as-is; and cc had follow up bits which went nowhere. I have hw-crypto offload working locally (as a start as we'll need more for suspend/resume eventually) so I'll push those changes instead.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
src/
173 lines

Diff 133497

View Options

sys/compat/linuxkpi/common/src/linux_80211.c

Loading...