Page MenuHomeFreeBSD

kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes
ClosedPublic

Authored by kevans on Jan 15 2024, 5:53 AM.
Tags
None
Referenced Files
F169479878: D43456.id132804.diff
Tue, Sep 1, 3:49 PM
F169451350: D43456.id.diff
Tue, Sep 1, 2:01 PM
Unknown Object (File)
Fri, Aug 28, 7:21 PM
Unknown Object (File)
Fri, Aug 28, 1:18 PM
Unknown Object (File)
Fri, Aug 28, 12:38 PM
Unknown Object (File)
Fri, Aug 21, 3:23 PM
Unknown Object (File)
Tue, Aug 18, 4:23 AM
Unknown Object (File)
Sun, Aug 16, 6:24 AM
Subscribers
None

Details

Summary

Before this change, we would canonicalize any partial input if the new
local mode is not ICANON, but that's about it. If we were switching
from -ICANON -> ICANON, or if VEOF/VEOL changes, then our internal canon
accounting would be wrong.

The main consequence of this is that in ICANON mode, we would potentially
hang a read(2) longer if the new VEOF/VEOL appears later in the buffer,
and FIONREAD would be similarly wrong as a result.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable