Page MenuHomeFreeBSD

kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes
ClosedPublic

Authored by kevans on Jan 15 2024, 5:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 20, 5:01 AM
Unknown Object (File)
Sun, May 17, 1:58 AM
Unknown Object (File)
Sun, May 17, 1:58 AM
Unknown Object (File)
Sun, May 17, 1:49 AM
Unknown Object (File)
Apr 29 2026, 7:25 AM
Unknown Object (File)
Apr 29 2026, 7:20 AM
Unknown Object (File)
Apr 29 2026, 1:23 AM
Unknown Object (File)
Apr 29 2026, 1:14 AM
Subscribers
None

Details

Summary

Before this change, we would canonicalize any partial input if the new
local mode is not ICANON, but that's about it. If we were switching
from -ICANON -> ICANON, or if VEOF/VEOL changes, then our internal canon
accounting would be wrong.

The main consequence of this is that in ICANON mode, we would potentially
hang a read(2) longer if the new VEOF/VEOL appears later in the buffer,
and FIONREAD would be similarly wrong as a result.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable