Page MenuHomeFreeBSD

kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes
ClosedPublic

Authored by kevans on Jan 15 2024, 5:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 25, 9:04 AM
Unknown Object (File)
Fri, Sep 25, 9:02 AM
Unknown Object (File)
Fri, Sep 25, 8:09 AM
Unknown Object (File)
Thu, Sep 17, 9:31 PM
Unknown Object (File)
Fri, Sep 11, 10:21 AM
Unknown Object (File)
Sun, Sep 6, 4:44 AM
Unknown Object (File)
Sat, Sep 5, 7:32 PM
Unknown Object (File)
Sat, Sep 5, 7:32 PM
Subscribers
None

Details

Summary

Before this change, we would canonicalize any partial input if the new
local mode is not ICANON, but that's about it. If we were switching
from -ICANON -> ICANON, or if VEOF/VEOL changes, then our internal canon
accounting would be wrong.

The main consequence of this is that in ICANON mode, we would potentially
hang a read(2) longer if the new VEOF/VEOL appears later in the buffer,
and FIONREAD would be similarly wrong as a result.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable