Page MenuHomeFreeBSD

kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes
ClosedPublic

Authored by kevans on Jan 15 2024, 5:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 7, 10:46 AM
Unknown Object (File)
Sun, Jul 5, 4:17 AM
Unknown Object (File)
Sat, Jul 4, 12:13 PM
Unknown Object (File)
Fri, Jul 3, 6:10 AM
Unknown Object (File)
Thu, Jul 2, 9:56 AM
Unknown Object (File)
May 20 2026, 5:01 AM
Unknown Object (File)
May 17 2026, 1:58 AM
Unknown Object (File)
May 17 2026, 1:58 AM
Subscribers
None

Details

Summary

Before this change, we would canonicalize any partial input if the new
local mode is not ICANON, but that's about it. If we were switching
from -ICANON -> ICANON, or if VEOF/VEOL changes, then our internal canon
accounting would be wrong.

The main consequence of this is that in ICANON mode, we would potentially
hang a read(2) longer if the new VEOF/VEOL appears later in the buffer,
and FIONREAD would be similarly wrong as a result.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable