Page MenuHomeFreeBSD

kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes
ClosedPublic

Authored by kevans on Jan 15 2024, 5:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 29, 9:23 AM
Unknown Object (File)
Wed, Jan 28, 2:12 PM
Unknown Object (File)
Wed, Jan 28, 10:00 AM
Unknown Object (File)
Wed, Jan 28, 9:40 AM
Unknown Object (File)
Tue, Jan 27, 8:20 AM
Unknown Object (File)
Dec 11 2025, 2:33 PM
Unknown Object (File)
Dec 8 2025, 12:13 PM
Unknown Object (File)
Dec 4 2025, 9:19 PM
Subscribers
None

Details

Summary

Before this change, we would canonicalize any partial input if the new
local mode is not ICANON, but that's about it. If we were switching
from -ICANON -> ICANON, or if VEOF/VEOL changes, then our internal canon
accounting would be wrong.

The main consequence of this is that in ICANON mode, we would potentially
hang a read(2) longer if the new VEOF/VEOL appears later in the buffer,
and FIONREAD would be similarly wrong as a result.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable