Page MenuHomeFreeBSD

kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes
ClosedPublic

Authored by kevans on Jan 15 2024, 5:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 11, 2:33 PM
Unknown Object (File)
Mon, Dec 8, 12:13 PM
Unknown Object (File)
Thu, Dec 4, 9:19 PM
Unknown Object (File)
Fri, Nov 28, 3:46 PM
Unknown Object (File)
Nov 11 2025, 9:11 AM
Unknown Object (File)
Nov 9 2025, 10:26 PM
Unknown Object (File)
Nov 2 2025, 9:28 PM
Unknown Object (File)
Nov 2 2025, 9:28 PM
Subscribers
None

Details

Summary

Before this change, we would canonicalize any partial input if the new
local mode is not ICANON, but that's about it. If we were switching
from -ICANON -> ICANON, or if VEOF/VEOL changes, then our internal canon
accounting would be wrong.

The main consequence of this is that in ICANON mode, we would potentially
hang a read(2) longer if the new VEOF/VEOL appears later in the buffer,
and FIONREAD would be similarly wrong as a result.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable