Page MenuHomeFreeBSD
Differential D43456

kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes
ClosedPublic
Actions

Authored by kevans on Jan 15 2024, 5:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 6, 4:44 AM
Unknown Object (File)
Sat, Sep 5, 7:32 PM
Unknown Object (File)
Sat, Sep 5, 7:32 PM
Unknown Object (File)
Sat, Sep 5, 5:35 PM
Unknown Object (File)
Sat, Sep 5, 5:34 PM
Unknown Object (File)
Thu, Sep 3, 5:56 PM
Unknown Object (File)
Thu, Sep 3, 4:09 PM
Unknown Object (File)
Thu, Sep 3, 1:55 PM
View All Files
Subscribers
None

Details

Reviewers
cy
imp
kib
Commits
rG522083ffbd1a: kern: tty: recanonicalize the buffer on ICANON/VEOF/VEOL changes
Summary

Before this change, we would canonicalize any partial input if the new
local mode is not ICANON, but that's about it. If we were switching
from -ICANON -> ICANON, or if VEOF/VEOL changes, then our internal canon
accounting would be wrong.

The main consequence of this is that in ICANON mode, we would potentially
hang a read(2) longer if the new VEOF/VEOL appears later in the buffer,
and FIONREAD would be similarly wrong as a result.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55442
Build 52331: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
kern/
22 lines
49 lines
22 lines
sys/
1 line
1 line

Diff 132773

View Options

sys/kern/tty.c

Loading...
View Options

sys/kern/tty_inq.c

Loading...
View Options

sys/kern/tty_ttydisc.c

Loading...
View Options

sys/sys/ttydisc.h

Loading...
View Options

sys/sys/ttyqueue.h

Loading...