Page MenuHomeFreeBSD
Differential D43431

hyperv vmbus_pcib: Use pci_domain_*_bus for PCI_RES_BUS resources
ClosedPublic
Actions

Authored by jhb on Jan 12 2024, 10:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 9, 9:37 PM
Unknown Object (File)
Mon, Dec 8, 3:32 AM
Unknown Object (File)
Sun, Dec 7, 11:15 PM
Unknown Object (File)
Sat, Dec 6, 10:58 PM
Unknown Object (File)
Sat, Dec 6, 12:27 AM
Unknown Object (File)
Sat, Nov 29, 12:33 AM
Unknown Object (File)
Fri, Nov 28, 8:49 AM
Unknown Object (File)
Tue, Nov 25, 10:21 AM
View All 89 Files
Subscribers
None

Details

Reviewers
imp
decui_microsoft.com
whu
schakrabarti_microsoft.com
Commits
rGd65f66c98337: hyperv vmbus_pcib: Use pci_domain_*_bus for PCI_RES_BUS resources
rG9c4effb1063d: hyperv vmbus_pcib: Use pci_domain_*_bus for PCI_RES_BUS resources
Summary

Specifically for bus_activate/adjust/deactivate_bus methods.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55405
Build 52294: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Jan 12 2024, 10:32 PM
jhb created this revision.
Harbormaster completed remote builds in B55405: Diff 132710.Jan 12 2024, 10:32 PM
jhb added a parent revision: D43430: x86: Use pci_domain_[de]activate_bus for PCI_RES_BUS resources.Jan 12 2024, 10:32 PM
jhb added a child revision: D43432: powerpc ps3bus: Use bus_generic_rman_*.
jhb added reviewers: decui_microsoft.com, whu.Jan 12 2024, 10:36 PM
lwhsu added a reviewer: schakrabarti_microsoft.com.Jan 17 2024, 3:02 PM
schakrabarti_microsoft.com added inline comments.Jan 18 2024, 3:36 AM
sys/dev/hyperv/pcib/vmbus_pcib.c
2011

Please check the indentation here.

jhb added inline comments.Jan 22 2024, 4:41 PM
sys/dev/hyperv/pcib/vmbus_pcib.c
2011

The raw version looks fine. I think the previous version was not fully consistent. Here is the patched method table:

	/* Bus interface */
	DEVMETHOD(bus_read_ivar,		vmbus_pcib_read_ivar),
	DEVMETHOD(bus_write_ivar,		vmbus_pcib_write_ivar),
	DEVMETHOD(bus_alloc_resource,		vmbus_pcib_alloc_resource),
	DEVMETHOD(bus_adjust_resource,		vmbus_pcib_adjust_resource),
	DEVMETHOD(bus_release_resource,		vmbus_pcib_release_resource),
	DEVMETHOD(bus_activate_resource,   	vmbus_pcib_activate_resource),
	DEVMETHOD(bus_deactivate_resource, 	vmbus_pcib_deactivate_resource),
	DEVMETHOD(bus_setup_intr,	   bus_generic_setup_intr),
	DEVMETHOD(bus_teardown_intr,	   bus_generic_teardown_intr),
	DEVMETHOD(bus_get_cpus,			vmbus_pcib_get_cpus),
This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2024, 5:46 PM
Closed by commit rG9c4effb1063d: hyperv vmbus_pcib: Use pci_domain_*_bus for PCI_RES_BUS resources (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG9c4effb1063d: hyperv vmbus_pcib: Use pci_domain_*_bus for PCI_RES_BUS resources.
schakrabarti_microsoft.com added a comment.Jan 24 2024, 7:00 AM

Code looks fine to me, but has the new functions been tested on Azure ? As in local Hyper-V we mostly dont use pci passthrough.

jhb added a comment.Jan 24 2024, 3:53 PM
In D43431#993619, @schakrabarti_microsoft.com wrote:

Code looks fine to me, but has the new functions been tested on Azure ? As in local Hyper-V we mostly dont use pci passthrough.

I do not have a means to test it, no. It is part of a larger API sweep/cleanup series.

jhb added a commit: rGd65f66c98337: hyperv vmbus_pcib: Use pci_domain_*_bus for PCI_RES_BUS resources.Feb 27 2025, 2:16 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
pcib/
41 lines

Diff 132710

View Options

sys/dev/hyperv/pcib/vmbus_pcib.c

Loading...