Page MenuHomeFreeBSD
Differential D43099

compat_freebsd4: Check for errors from subyte() in freebsd4_uname()
ClosedPublic
Actions

Authored by markj on Dec 19 2023, 3:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 24, 7:11 PM
Unknown Object (File)
Thu, Sep 24, 7:10 PM
Unknown Object (File)
Thu, Sep 24, 6:39 PM
Unknown Object (File)
Thu, Sep 24, 4:59 PM
Unknown Object (File)
Mon, Sep 14, 11:20 PM
Unknown Object (File)
Sat, Sep 5, 12:24 PM
Unknown Object (File)
Aug 29 2026, 5:31 PM
Unknown Object (File)
Aug 15 2026, 4:05 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
jhb
imp
Commits
rG6b067be54eda: compat_freebsd4: Check for errors from subyte() in freebsd4_uname()
rG81ee40d0a269: compat_freebsd4: Check for errors from subyte() in freebsd4_uname()
rG4f35450ce52a: compat_freebsd4: Check for errors from subyte() in freebsd4_uname()
Summary

This is in preparation for adding a __result_use_check annotation to
copyin() and related functions.

Possibly the right thing to do here is to instead suppress errors with a
cast to void, since that's more compatible with the existing behaviour.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55005
Build 51894: arc lint + arc unit

Event Timeline

markj created this revision.Dec 19 2023, 3:13 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 19 2023, 3:13 AM
markj requested review of this revision.Dec 19 2023, 3:13 AM
Harbormaster completed remote builds in B55005: Diff 131550.Dec 19 2023, 3:14 AM
markj added a child revision: D43100: thread: Add a return value to cpu_set_upcall().Dec 19 2023, 3:14 AM
kib accepted this revision.Dec 19 2023, 7:54 AM
This revision is now accepted and ready to land.Dec 19 2023, 7:54 AM
jhb accepted this revision.Dec 20 2023, 8:28 PM
imp accepted this revision.Dec 22 2023, 12:02 AM
Closed by commit rG4f35450ce52a: compat_freebsd4: Check for errors from subyte() in freebsd4_uname() (authored by markj). · Explain WhyDec 26 2023, 2:04 AM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG4f35450ce52a: compat_freebsd4: Check for errors from subyte() in freebsd4_uname().
markj added a commit: rG81ee40d0a269: compat_freebsd4: Check for errors from subyte() in freebsd4_uname().Jan 2 2024, 12:38 AM
markj added a commit: rG6b067be54eda: compat_freebsd4: Check for errors from subyte() in freebsd4_uname().Jan 2 2024, 1:15 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
16 lines

Diff 131550

View Options

sys/kern/kern_xxx.c

Loading...