Page MenuHomeFreeBSD
Differential D42810

LinuxKPI: Add write_seqcount_invalidate() and seqprop_sequence()
ClosedPublic
Actions

Authored by wulf on Nov 28 2023, 9:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 23, 2:49 PM
Unknown Object (File)
Sun, Sep 20, 10:27 PM
Unknown Object (File)
Sun, Sep 20, 10:48 AM
Unknown Object (File)
Fri, Sep 18, 4:53 AM
Unknown Object (File)
Thu, Sep 17, 4:58 AM
Unknown Object (File)
Sun, Sep 13, 10:42 AM
Unknown Object (File)
Fri, Sep 11, 8:55 AM
Unknown Object (File)
Thu, Sep 3, 9:14 PM
View All Files
Subscribers
emaste
imp
linuxkpi

Details

Reviewers
manu
dumbbell
bz
Commits
rGada94bf9e8cb: LinuxKPI: Add write_seqcount_invalidate() and seqprop_sequence()
rG64e30cba3f04: LinuxKPI: Add write_seqcount_invalidate() and seqprop_sequence()
Summary

functions to linux/seqlock.h

Sponsored by: Serenity Cyber Security, LLC
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54666
Build 51555: arc lint + arc unit

Event Timeline

wulf created this revision.Nov 28 2023, 9:11 PM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptNov 28 2023, 9:11 PM
wulf requested review of this revision.Nov 28 2023, 9:11 PM
Harbormaster completed remote builds in B54666: Diff 130695.Nov 28 2023, 9:11 PM
wulf added a reviewer: bz.Nov 28 2023, 10:45 PM
manu accepted this revision.Nov 29 2023, 6:14 AM
This revision is now accepted and ready to land.Nov 29 2023, 6:14 AM
bz requested changes to this revision.Dec 8 2023, 5:40 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/seqlock.h
93

I would put a comment there; almost wants sys/seqc.h integration?

180

Do you want seqc_read_notmodify()?

This revision now requires changes to proceed.Dec 8 2023, 5:40 PM
wulf updated this revision to Diff 131217.Dec 9 2023, 2:21 PM

READ_ONCE -> atomic_load_int

wulf added inline comments.Dec 9 2023, 2:26 PM
sys/compat/linuxkpi/common/include/linux/seqlock.h
93

I do not understand what type comment and integration you expect? Move this code to sys/seqc.h and make write_seqcount_invalidate a wrapper?

180

No. It's relaxed version of seqc_read_notmodify()
I replaced READ_ONCE() with atomic_load() to make things clearer

wulf updated this revision to Diff 131234.Dec 10 2023, 7:18 PM

Allow new functions to work with mutex-less seqcounts

This revision was not accepted when it landed; it landed in state Needs Review.Dec 24 2023, 8:24 AM
Closed by commit rG64e30cba3f04: LinuxKPI: Add write_seqcount_invalidate() and seqprop_sequence() (authored by wulf). · Explain Why
This revision was automatically updated to reflect the committed changes.
wulf added a commit: rG64e30cba3f04: LinuxKPI: Add write_seqcount_invalidate() and seqprop_sequence().
wulf added a commit: rGada94bf9e8cb: LinuxKPI: Add write_seqcount_invalidate() and seqprop_sequence().Feb 17 2024, 9:34 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
15 lines

Diff 130695

View Options

sys/compat/linuxkpi/common/include/linux/seqlock.h

Loading...