Page MenuHomeFreeBSD
Differential D37013

devel/binutils: Add INFO option
ClosedPublic
Actions

Authored by firk_cantconnect.ru on Oct 16 2022, 6:14 PM.
Tags
None
Referenced Files
F103617849: D37013.diff
Wed, Nov 27, 5:03 AM
Unknown Object (File)
Sun, Nov 24, 6:26 AM
Unknown Object (File)
Sat, Nov 23, 3:28 AM
Unknown Object (File)
Thu, Nov 21, 5:08 AM
Unknown Object (File)
Wed, Nov 20, 12:18 PM
Unknown Object (File)
Thu, Nov 7, 7:09 AM
Unknown Object (File)
Wed, Nov 6, 7:37 PM
Unknown Object (File)
Wed, Nov 6, 3:09 AM
View All 100 Files
Subscribers
None

Details

Reviewers
arrowd
cy
Commits
R11:732684602aa2: devel/binutils: Add INFO option
Summary

Add INFO option to remove unconditional texinfo dependency.

PR: 275378

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

firk_cantconnect.ru requested review of this revision.Oct 16 2022, 6:14 PM
firk_cantconnect.ru created this revision.
firk_cantconnect.ru updated this revision to Diff 130614.Nov 27 2023, 3:50 PM

Rebased the diff to new port version (2.37 -> 2.40)

firk_cantconnect.ru edited the summary of this revision. (Show Details)Nov 27 2023, 3:54 PM
cy retitled this revision from Add INFO option to devel/binutils to get rid of unconditional texinfo dependency to devel/binutils: Add INFO option.Nov 27 2023, 4:02 PM
cy edited the summary of this revision. (Show Details)
cy added a comment.Nov 27 2023, 4:09 PM

/tmp/D37013.diff:50: space before tab in indent.

	$(MAKE) $(AM_MAKEFLAGS) check-recursive

/tmp/D37013.diff:53: space before tab in indent.

		config.h

/tmp/D37013.diff:57: trailing whitespace.

/tmp/D37013.diff:59: trailing whitespace.

/tmp/D37013.diff:63: trailing whitespace.

cy added inline comments.Nov 27 2023, 4:14 PM
devel/binutils/files/extra-patch-no-info
2

Please prefix this line with your email address in a comment. This patch will almost certainly break every time binutils is updated. I would like to ask you to support this patch as needed.

firk_cantconnect.ru added a comment.Nov 27 2023, 5:54 PM
In D37013#975828, @cy wrote:

/tmp/D37013.diff:50: space before tab in indent.

	$(MAKE) $(AM_MAKEFLAGS) check-recursive

This and next lines are part of the patch about creating a patch-file, so they have two first characters of unified diff syntax.

firk_cantconnect.ru updated this revision to Diff 130624.Nov 27 2023, 6:23 PM
firk_cantconnect.ru added inline comments.
devel/binutils/files/extra-patch-no-info
2

done

cy requested changes to this revision.Nov 27 2023, 7:24 PM
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/info/ctf-spec.info
Error: Orphaned: share/info/sframe-spec.info
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/binutils
This revision now requires changes to proceed.Nov 27 2023, 7:24 PM
firk_cantconnect.ru updated this revision to Diff 130627.Nov 27 2023, 10:34 PM

fix unwanted info files when INFO disabled

firk_cantconnect.ru added a comment.Nov 27 2023, 10:37 PM
In D37013#975891, @cy wrote:
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/info/ctf-spec.info
Error: Orphaned: share/info/sframe-spec.info
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/binutils

Fixed these two files too.
Idk why other infos fails on missing makeinfo and this two doesn't and instead installing pregenerated ones.

cy accepted this revision.Nov 28 2023, 12:13 AM

LGTM.

Prior to commit, can I please have your full name and email address so that I can fill in the --author field?

The subject line and summary have been adjusted to make for a good commit log message.

This revision is now accepted and ready to land.Nov 28 2023, 12:13 AM
cy added a comment.Nov 28 2023, 12:15 AM

BTW, the name firk is not appropriate in the tree.

firk_cantconnect.ru added a comment.Nov 28 2023, 5:23 AM
In D37013#975931, @cy wrote:

LGTM.

Prior to commit, can I please have your full name and email address so that I can fill in the --author field?

The subject line and summary have been adjusted to make for a good commit log message.

Alexander Firk <firk@cantconnect.ru>

Where could I fill this info to make it automatically used for my patches?

Closed by commit R11:732684602aa2: devel/binutils: Add INFO option (authored by firk_cantconnect.ru, committed by cy). · Explain WhyNov 30 2023, 4:35 AM
This revision was automatically updated to reflect the committed changes.
cy added a commit: R11:732684602aa2: devel/binutils: Add INFO option.
cy added a comment.Dec 1 2023, 12:43 AM
In D37013#975963, @firk_cantconnect.ru wrote:
In D37013#975931, @cy wrote:

LGTM.

Prior to commit, can I please have your full name and email address so that I can fill in the --author field?

The subject line and summary have been adjusted to make for a good commit log message.

Alexander Firk <firk@cantconnect.ru>

Where could I fill this info to make it automatically used for my patches?

No worries. Another committer accepted your name as is. So I figured it must be ok.

BTW, my .gitconfig file contains this:

[user]
        email = cy@FreeBSD.org
        name = Cy Schubert

This fills in my name and FreeBSD email correctly. It looks a little more professional too.

A person could have different user information for each repo. If you're working on different projects for different employers, each repo could contain a different email address.

Revision Contents
Changeset List

PathSize
devel/
binutils/
9 lines
files/
112 lines

Diff 130624

View Options

devel/binutils/Makefile

Loading...
View Options

devel/binutils/files/extra-patch-no-info

Loading...