Page MenuHomeFreeBSD

makesyscalls: don't make syscall.mk by default
ClosedPublic

Authored by brooks on Nov 17 2023, 7:52 PM.
Tags
None
Referenced Files
F154996419: D42663.id.diff
Thu, Apr 30, 1:56 PM
Unknown Object (File)
Tue, Apr 28, 5:56 AM
Unknown Object (File)
Tue, Apr 28, 1:03 AM
Unknown Object (File)
Mon, Apr 27, 9:01 PM
Unknown Object (File)
Mon, Apr 27, 4:14 PM
Unknown Object (File)
Mon, Apr 20, 4:39 AM
Unknown Object (File)
Sun, Apr 19, 4:52 AM
Unknown Object (File)
Sat, Apr 4, 10:27 PM
Subscribers

Details

Summary

We only want to produce syscall.mk for the main syscall table so default
to not producing it (send it to /dev/null) and add a syscalls.conf to
sys/kern to trigger the creation of sys/sys/syscall.mk. This eliminates
the need for entries in other syscalls.conf files and is a cleaner
pattern going forward.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54499
Build 51388: arc lint + arc unit

Event Timeline

It might not be a bad idea to later special-case /dev/null in a couple places so that we don't even bother writing temp files in the first place (i.e. shim it out in write_line and a couple other places to nops).

This revision is now accepted and ready to land.Nov 17 2023, 8:26 PM

Likely not worth special case...
I have a refactoring that makes this run in libc in a make friendly way...

FWIW, I hit this because I'm looking at generating parts of lib/libc/sys/Symbol.map on the way to a long overdue reimplementation of D14609. Fortunately it's quite a minor change that just touches all the places sysmk support does (unless I decide to generate more of the file which would require annotations).