Page MenuHomeFreeBSD
Differential D42615

libc: centralize ntoh symbols
ClosedPublic
Actions

Authored by brooks on Nov 15 2023, 4:02 PM.
Tags
None
Referenced Files
F146779339: D42615.id130181.diff
Thu, Mar 5, 1:02 PM
Unknown Object (File)
Thu, Mar 5, 12:28 AM
Unknown Object (File)
Mon, Mar 2, 3:47 AM
Unknown Object (File)
Mon, Mar 2, 3:36 AM
Unknown Object (File)
Mon, Mar 2, 3:36 AM
Unknown Object (File)
Sun, Feb 22, 3:14 PM
Unknown Object (File)
Fri, Feb 20, 8:51 PM
Unknown Object (File)
Tue, Feb 10, 8:33 AM
View All 78 Files
Subscribers
None

Details

Reviewers
kib
imp
emaste
andrew
Commits
rG9d67dced8385: libc: centralize ntoh symbols
rGff3a9d8e2909: libc: centralize ntoh symbols
Summary

These are implemented by net/ntoh.c via headers and compiler intrinsics
so declare them in net/Symbol.map.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54449
Build 51339: arc lint + arc unit

Event Timeline

brooks created this revision.Nov 15 2023, 4:02 PM
Herald added a reviewer: andrew. · View Herald TranscriptNov 15 2023, 4:02 PM
Herald added a reviewer: andrew. · View Herald Transcript
brooks requested review of this revision.Nov 15 2023, 4:02 PM
Harbormaster completed remote builds in B54449: Diff 130136.Nov 15 2023, 4:02 PM
brooks added a parent revision: D42614: libc: further centralize syscall symbols.Nov 15 2023, 4:02 PM
brooks added a child revision: D42616: libc: centralize {_,sig,}{set,long}jmp symbols.
emaste accepted this revision.Nov 15 2023, 6:32 PM

Yes these shouldn't have been MD

This revision is now accepted and ready to land.Nov 15 2023, 6:32 PM
imp accepted this revision.Nov 15 2023, 10:05 PM
kib added inline comments.Nov 15 2023, 10:31 PM
lib/libc/net/Symbol.map
69

Shouldn't 'ntoh*' placed in the 'n' block of the version?

brooks added inline comments.Nov 15 2023, 11:09 PM
lib/libc/net/Symbol.map
69

This file (for good or ill) seem to group things by function and only loosely alphabetically. For example see the get* above with related end* and set*.

kib accepted this revision.Nov 15 2023, 11:10 PM
Closed by commit rGff3a9d8e2909: libc: centralize ntoh symbols (authored by brooks). · Explain WhyNov 15 2023, 11:47 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGff3a9d8e2909: libc: centralize ntoh symbols.
brooks added a commit: rG9d67dced8385: libc: centralize ntoh symbols.Dec 13 2023, 10:30 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
aarch64/
4 lines
amd64/
4 lines
arm/
4 lines
i386/
4 lines
net/
4 lines
powerpc/
4 lines
powerpc64/
4 lines
riscv/
4 lines

Diff 130136

View Options

lib/libc/aarch64/Symbol.map

Loading...
View Options

lib/libc/amd64/Symbol.map

Loading...
View Options

lib/libc/arm/Symbol.map

Loading...
View Options

lib/libc/i386/Symbol.map

Loading...
View Options

lib/libc/net/Symbol.map

Loading...
View Options

lib/libc/powerpc/Symbol.map

Loading...
View Options

lib/libc/powerpc64/Symbol.map

Loading...
View Options

lib/libc/riscv/Symbol.map

Loading...