hyperv/hn: Increase LRO entry count to 128 by default
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Feb 2 2016, 10:22 AM.

Details

Reviewers

howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger
adrian

Group Reviewers

network

Commits

rS295304: hyperv/hn: Increase LRO entry count to 128 by default

Summary

hn(4) only has one RX ring, so default 8 LRO entries are too small.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sepherosa_gmail.com updated this revision to Diff 12947.Feb 2 2016, 10:22 AM

sepherosa_gmail.com retitled this revision from to hyperv/hn: Increase LRO entry count to 128 by default.

sepherosa_gmail.com updated this object.

sepherosa_gmail.com edited the test plan for this revision. (Show Details)

sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.

sepherosa_gmail.com added a subscriber: freebsd-net-list.

adrian accepted this revision.Feb 4 2016, 3:42 AM

adrian edited edge metadata.

This revision is now accepted and ready to land.Feb 4 2016, 3:42 AM

Closed by commit rS295304: hyperv/hn: Increase LRO entry count to 128 by default (authored by sephe). · Explain WhyFeb 5 2016, 5:38 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hyperv/

netvsc/

hv_netvsc_drv_freebsd.c

28 lines

Diff 12947

View Options

sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c

Show First 20 Lines • Show All 211 Lines • ▼ Show 20 Lines	if ((frame->tf_scause == EXCP_FAULT_STORE) \|\|
ftype = VM_PROT_EXECUTE;		ftype = VM_PROT_EXECUTE;
} else {		} else {
ftype = VM_PROT_READ;		ftype = VM_PROT_READ;
}		}

if (pmap_fault_fixup(map->pmap, va, ftype))		if (pmap_fault_fixup(map->pmap, va, ftype))
goto done;		goto done;

if (map != kernel_map) {		error = vm_fault_trap(map, va, ftype, VM_FAULT_NORMAL, &sig, &ucode);
/*
* Keep swapout from messing with us during this
* critical time.
*/
PROC_LOCK(p);
++p->p_lock;
PROC_UNLOCK(p);

/* Fault in the user page: */
error = vm_fault(map, va, ftype, VM_FAULT_NORMAL);

PROC_LOCK(p);
--p->p_lock;
PROC_UNLOCK(p);
} else {
/*
* Don't have to worry about process locking or stacks in the
* kernel.
*/
error = vm_fault(map, va, ftype, VM_FAULT_NORMAL);
}

alcUnsubmitted Done Inline Actions I'm surprised to see this snippet brought back to life in the riscv code. We removed it from elsewhere in the source tree almost exactly 4 years ago (r287625). I would suggest committing the removal of this snippet now, and thus separately from the rest. alc: I'm surprised to see this snippet brought back to life in the riscv code. We removed it from…
if (error != KERN_SUCCESS) {		if (error != KERN_SUCCESS) {
if (usermode) {		if (usermode) {
sig = SIGSEGV;
if (error == KERN_PROTECTION_FAILURE)
ucode = SEGV_ACCERR;
else
ucode = SEGV_MAPERR;
call_trapsignal(td, sig, ucode, (void *)stval);		call_trapsignal(td, sig, ucode, (void *)stval);
} else {		} else {
if (pcb->pcb_onfault != 0) {		if (pcb->pcb_onfault != 0) {
frame->tf_a[0] = error;		frame->tf_a[0] = error;
frame->tf_sepc = pcb->pcb_onfault;		frame->tf_sepc = pcb->pcb_onfault;
return;		return;
}		}
goto fatal;		goto fatal;
▲ Show 20 Lines • Show All 139 Lines • Show Last 20 Lines

hyperv/hn: Increase LRO entry count to 128 by defaultClosedPublicActions