ping: Simplify protocol selection.
ClosedPublic
Actions

Authored by des on Oct 9 2023, 4:52 PM.

Details

Reviewers

Group Reviewers

Klara

Commits

Summary

Interrupt the option loop as soon as we have an indication of which protocol is intended.
If we end up having to perform a DNS lookup, loop over the entire result looking for either IPv4 or IPv6 addresses.

Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 53912
Build 50802: arc lint + arc unit

des created this revision.Oct 9 2023, 4:52 PM

des requested review of this revision.Oct 9 2023, 4:52 PM

This revision is now accepted and ready to land.Oct 9 2023, 5:27 PM

fall through

This revision now requires review to proceed.Oct 9 2023, 8:01 PM

des edited the summary of this revision. (Show Details)Oct 9 2023, 8:01 PM

reviewed-by: allanjude

This revision is now accepted and ready to land.Oct 9 2023, 8:58 PM

des added inline comments.Oct 9 2023, 9:03 PM

sbin/ping/main.c
145–146	I can't make up my mind about this... if `getaddrinfo()` didn't return anything useful, that's not likely to change. Should I put the `errx(1, "Unknown host")` back? (above the `#endif` though)