hyperv/hn: Avoid duplicate csum features settings
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Jan 27 2016, 7:02 AM.

Details

Reviewers

howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger
adrian

Group Reviewers

network

Commits

rS295296: hyperv/hn: Avoid duplicate csum features settings

Summary

Record csum features in softc, so we don't need to duplicate the logic from attach path to ioctl path.
Protect if_capenable and if_hwassist changes by main lock.
Prefer turn on/off bits in if_hwassist explicitly instead of using XOR.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sepherosa_gmail.com updated this revision to Diff 12744.Jan 27 2016, 7:02 AM

sepherosa_gmail.com retitled this revision from to hyperv/hn: Avoid duplicate csum features settings.

sepherosa_gmail.com updated this object.

sepherosa_gmail.com edited the test plan for this revision. (Show Details)

sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.

sepherosa_gmail.com added a subscriber: freebsd-net-list.

LGTM

This revision is now accepted and ready to land.Jan 28 2016, 7:58 AM

adrian accepted this revision.Jan 28 2016, 5:06 PM

adrian edited edge metadata.

Closed by commit rS295296: hyperv/hn: Avoid duplicate csum features settings (authored by sephe). · Explain WhyFeb 5 2016, 4:04 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hyperv/

netvsc/

hv_net_vsc.h

2 lines

hv_netvsc_drv_freebsd.c

64 lines

Diff 12744

View Options

sys/dev/hyperv/netvsc/hv_net_vsc.h