irdma(4): use related vnet for searching netdev
ClosedPublic
Actions

Authored by bartosz.sobczak_intel.com on Aug 24 2023, 8:35 PM.

Details

Reviewers

kib
erj

Group Reviewers

Intel Networking
NetApp

Commits

rGd4a087dcba62: irdma(4): use related vnet for searching netdev
rGe3b352597e4b: irdma(4): use related vnet for searching netdev
rGcc1abdc6ab34: irdma(4): use related vnet for searching netdev
rGbc3a013ccd23: irdma(4): use related vnet for searching netdev

Summary

It was found through testing that when ULP uses individual vnet, the search for the correct vlan_id may failing because of no proper interface with given address.

The solution is to use vnet associated to the connection whenever possible.

Signed-off-by: Bartosz Sobczak <bartosz.sobczak@intel.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartosz.sobczak_intel.com created this revision.Aug 24 2023, 8:35 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 24 2023, 8:35 PM

bartosz.sobczak_intel.com requested review of this revision.Aug 24 2023, 8:35 PM

bartosz.sobczak_intel.com edited the summary of this revision. (Show Details)Aug 25 2023, 6:26 AM

erj accepted this revision.Sep 12 2023, 9:27 PM

This revision is now accepted and ready to land.Sep 12 2023, 9:27 PM

anzhu_netapp.com added a subscriber: anzhu_netapp.com.Sep 13 2023, 6:34 PM

anzhu_netapp.com added inline comments.

sys/dev/irdma/irdma_cm.c
1648	ip6_ifp_find() is independent of VIMAGE. It can take "vnet" as input parameter unconditionally. Would it be simplified if vnet is declared with the default value "&init_net"?
1677	Same. ip_ifp_find() is independent of VIMAGE. It can take "vnet" as input parameter unconditionally. Would it be simplified if vnet is declared with the default value "&init_net"?

I was preparing to push this yesterday, but I forgot to do the last step; I think @anzhu_netapp.com has a good point here because it'll reduce the number of VIMAGE blocks, but I probably would still push it and would just wait for a fix later.

In D41592#953793, @erj wrote:

I was preparing to push this yesterday, but I forgot to do the last step; I think @anzhu_netapp.com has a good point here because it'll reduce the number of VIMAGE blocks, but I probably would still push it and would just wait for a fix later.

Yeah, i agree, we can do that arrangement. I'll prepare subsequent change as soon as possible, in the meantime i think it could go in as it is.

Closed by commit rGbc3a013ccd23: irdma(4): use related vnet for searching netdev (authored by bartosz.sobczak_intel.com, committed by erj). · Explain WhySep 13 2023, 10:17 PM

This revision was automatically updated to reflect the committed changes.

erj added a commit: rGbc3a013ccd23: irdma(4): use related vnet for searching netdev.

Yep, cosmetic issue can be addressed separately.

erj added a commit: rGcc1abdc6ab34: irdma(4): use related vnet for searching netdev.Sep 22 2023, 8:48 PM

erj added a commit: rGe3b352597e4b: irdma(4): use related vnet for searching netdev.Sep 22 2023, 9:57 PM

erj added a commit: rGd4a087dcba62: irdma(4): use related vnet for searching netdev.Sep 28 2023, 10:17 PM