Differential D41846

powerpc pmap: initialize kernel pmap radix trie
ClosedPublic
Actions

Authored by dougm on Sep 13 2023, 5:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sep 27 2024, 8:14 AM

	Unknown Object (File)
	Sep 22 2024, 2:22 AM

	Unknown Object (File)
	Sep 21 2024, 8:27 PM

	Unknown Object (File)
	Sep 21 2024, 3:59 PM

	Unknown Object (File)
	Sep 18 2024, 3:18 AM

	Unknown Object (File)
	Sep 17 2024, 5:26 PM

	Unknown Object (File)
	Sep 16 2024, 6:36 PM

	Unknown Object (File)
	Sep 16 2024, 5:01 PM

View All 38 Files

Subscribers

Details

Reviewers

alc
kib
jhibbits

Commits

rGd9b8e5a74805: powerpc pmap: initialize kernel pmap radix trie
rGa4c7a3f7f56a: powerpc pmap: initialize kernel pmap radix trie
rG8763b9862f90: powerpc pmap: initialize kernel pmap radix trie

Summary

Commit 2d2bcba7ba70141388729ed49674b36fd01146c5 changed radix trie implementation and made it necessary that radix tries be initialized with vm_radix_init. @dbaio reports that in some configurations, there is a powerpc boot panic and that this commit introduced the problem. In powerpc/aim/mmu_radix.c, the radix trie in kernel_pmap is initialized by zeroing all its fields.

Add a call to vm_radix_init to properly initialize kernel_pmap->pm_radix.

Test Plan

@dbaio reports that this change addresses the problem he has observed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm created this revision.Sep 13 2023, 5:33 PM

Herald added a subscriber: jhibbits. · View Herald TranscriptSep 13 2023, 5:33 PM

dougm requested review of this revision.Sep 13 2023, 5:33 PM

jhibbits accepted this revision.Sep 13 2023, 5:59 PM

This revision is now accepted and ready to land.Sep 13 2023, 5:59 PM

alc accepted this revision.Sep 13 2023, 6:16 PM

Closed by commit rG8763b9862f90: powerpc pmap: initialize kernel pmap radix trie (authored by dougm). · Explain WhySep 13 2023, 6:22 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rG8763b9862f90: powerpc pmap: initialize kernel pmap radix trie.

Herald added a subscriber: imp. · View Herald TranscriptSep 13 2023, 6:22 PM

dougm added a commit: rGa4c7a3f7f56a: powerpc pmap: initialize kernel pmap radix trie.Sep 20 2023, 2:11 AM

Can you also MFS to releng/14.0?

In D41846#955679, @pkubaj wrote:

Can you also MFS to releng/14.0?

If whoever is in charge of that gives me permission, I'll do it.

Well, you need to ask re@ and since it was your fix, you should probably be the one to do it.

In D41846#955841, @pkubaj wrote:

Well, you need to ask re@ and since it was your fix, you should probably be the one to do it.

I've asked. No response yet.

dougm added a commit: rGd9b8e5a74805: powerpc pmap: initialize kernel pmap radix trie.Sep 23 2023, 1:55 AM

Revision Contents
Changeset List

Path

Size

sys/

powerpc/

aim/

1 line

Diff 127340

sys/powerpc/aim/mmu_radix.c

Loading...