Page MenuHomeFreeBSD

powerpc pmap: initialize kernel pmap radix trie
ClosedPublic

Authored by dougm on Sep 13 2023, 5:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 26 2024, 6:31 AM
Unknown Object (File)
Dec 31 2023, 3:37 PM
Unknown Object (File)
Dec 31 2023, 3:37 PM
Unknown Object (File)
Dec 23 2023, 3:09 AM
Unknown Object (File)
Dec 12 2023, 6:24 AM
Unknown Object (File)
Nov 6 2023, 3:49 PM
Unknown Object (File)
Sep 13 2023, 6:22 PM

Details

Summary

Commit 2d2bcba7ba70141388729ed49674b36fd01146c5 changed radix trie implementation and made it necessary that radix tries be initialized with vm_radix_init. @dbaio reports that in some configurations, there is a powerpc boot panic and that this commit introduced the problem. In powerpc/aim/mmu_radix.c, the radix trie in kernel_pmap is initialized by zeroing all its fields.

Add a call to vm_radix_init to properly initialize kernel_pmap->pm_radix.

Test Plan

@dbaio reports that this change addresses the problem he has observed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Sep 13 2023, 5:33 PM
This revision is now accepted and ready to land.Sep 13 2023, 5:59 PM

Can you also MFS to releng/14.0?

Can you also MFS to releng/14.0?

If whoever is in charge of that gives me permission, I'll do it.

Well, you need to ask re@ and since it was your fix, you should probably be the one to do it.

Well, you need to ask re@ and since it was your fix, you should probably be the one to do it.

I've asked. No response yet.