Page MenuHomeFreeBSD
Differential D41510

libc: Fix parsing of hexadecimal numbers in strtol() family.
ClosedPublic
Actions

Authored by des on Aug 19 2023, 11:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 12, 2:07 PM
Unknown Object (File)
Wed, Apr 9, 10:16 PM
Unknown Object (File)
Wed, Apr 9, 9:51 AM
Unknown Object (File)
Tue, Apr 1, 8:45 PM
Unknown Object (File)
Feb 27 2025, 3:46 AM
Unknown Object (File)
Feb 27 2025, 12:44 AM
Unknown Object (File)
Feb 26 2025, 10:55 AM
Unknown Object (File)
Feb 25 2025, 10:15 PM
View All 78 Files
Subscribers
allanjude
asiciliano
imp

Details

Reviewers
allanjude
emaste
imp
Commits
rG3b95950fa3f4: libc: Fix parsing of hexadecimal numbers in strtol() family.
rGb8b6bef43f87: libc: Fix parsing of hexadecimal numbers in strtol() family.
Summary

This had previously been partly fixed in 2571c7f7200f.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53175
Build 50066: arc lint + arc unit

Event Timeline

des created this revision.Aug 19 2023, 11:46 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 19 2023, 11:46 PM
des requested review of this revision.Aug 19 2023, 11:46 PM
Harbormaster completed remote builds in B53175: Diff 126240.Aug 19 2023, 11:46 PM
des added a child revision: D41511: libc: Implement N2630..Aug 19 2023, 11:46 PM
des updated this revision to Diff 126243.Aug 19 2023, 11:55 PM

add missing L prefixes

Harbormaster completed remote builds in B53178: Diff 126243.Aug 19 2023, 11:55 PM
asiciliano added a subscriber: asiciliano.Aug 20 2023, 12:38 AM
allanjude accepted this revision.Aug 21 2023, 2:39 PM
allanjude added a subscriber: allanjude.

Reviewed-by: allanjude

This revision is now accepted and ready to land.Aug 21 2023, 2:39 PM
emaste accepted this revision.Aug 21 2023, 5:30 PM
imp accepted this revision.Aug 21 2023, 5:31 PM

Same repetition comment as in D41511

Closed by commit rGb8b6bef43f87: libc: Fix parsing of hexadecimal numbers in strtol() family. (authored by des). · Explain WhyAug 24 2023, 9:51 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGb8b6bef43f87: libc: Fix parsing of hexadecimal numbers in strtol() family..
des added a commit: rG3b95950fa3f4: libc: Fix parsing of hexadecimal numbers in strtol() family..Sep 7 2023, 2:54 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
iconv/
5 lines
5 lines
locale/
5 lines
5 lines
5 lines
5 lines
5 lines
5 lines

Diff 126240

View Options

lib/libc/iconv/_strtol.h

Show All 22 Lines
.\" SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS .\" SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
.\" INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN .\" INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
.\" CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) .\" CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
.\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
.\" POSSIBILITY OF SUCH DAMAGE. .\" POSSIBILITY OF SUCH DAMAGE.
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd April 28, 2017 .Dd November 9, 2018
.Dt EDITLINE 3 .Dt EDITLINE 3
.Os .Os
.Sh NAME .Sh NAME
.Nm editline , .Nm editline ,
.Nm el_init , .Nm el_init ,
.Nm el_init_fd , .Nm el_init_fd ,
.Nm el_end , .Nm el_end ,
.Nm el_reset , .Nm el_reset ,
▲ Show 20 Lines • Show All 138 Lines • ▼ Show 20 Lines
.Pp .Pp
The The
.Nm .Nm
library respects the library respects the
.Ev LC_CTYPE .Ev LC_CTYPE
locale set by the application program and never uses locale set by the application program and never uses
.Xr setlocale 3 .Xr setlocale 3
to change the locale. to change the locale.
The only locales supported are UTF-8 and the default C or POSIX locale.
If any other locale is set, behaviour is undefined.
.Sh LINE EDITING FUNCTIONS .Sh LINE EDITING FUNCTIONS
The line editing functions use a common data structure, The line editing functions use a common data structure,
.Fa EditLine , .Fa EditLine ,
which is created by which is created by
.Fn el_init .Fn el_init
or or
.Fn el_init_fd .Fn el_init_fd
and freed by and freed by
▲ Show 20 Lines • Show All 782 Lines • Show Last 20 Lines
View Options

lib/libc/iconv/_strtoul.h

Show All 22 Lines
.\" SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS .\" SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
.\" INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN .\" INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
.\" CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) .\" CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
.\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
.\" POSSIBILITY OF SUCH DAMAGE. .\" POSSIBILITY OF SUCH DAMAGE.
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd April 28, 2017 .Dd November 9, 2018
.Dt EDITLINE 3 .Dt EDITLINE 3
.Os .Os
.Sh NAME .Sh NAME
.Nm editline , .Nm editline ,
.Nm el_init , .Nm el_init ,
.Nm el_init_fd , .Nm el_init_fd ,
.Nm el_end , .Nm el_end ,
.Nm el_reset , .Nm el_reset ,
▲ Show 20 Lines • Show All 138 Lines • ▼ Show 20 Lines
.Pp .Pp
The The
.Nm .Nm
library respects the library respects the
.Ev LC_CTYPE .Ev LC_CTYPE
locale set by the application program and never uses locale set by the application program and never uses
.Xr setlocale 3 .Xr setlocale 3
to change the locale. to change the locale.
The only locales supported are UTF-8 and the default C or POSIX locale.
If any other locale is set, behaviour is undefined.
.Sh LINE EDITING FUNCTIONS .Sh LINE EDITING FUNCTIONS
The line editing functions use a common data structure, The line editing functions use a common data structure,
.Fa EditLine , .Fa EditLine ,
which is created by which is created by
.Fn el_init .Fn el_init
or or
.Fn el_init_fd .Fn el_init_fd
and freed by and freed by
▲ Show 20 Lines • Show All 782 Lines • Show Last 20 Lines
View Options

lib/libc/locale/wcstoimax.c

Show All 22 Lines
.\" SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS .\" SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
.\" INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN .\" INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
.\" CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) .\" CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
.\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
.\" POSSIBILITY OF SUCH DAMAGE. .\" POSSIBILITY OF SUCH DAMAGE.
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd April 28, 2017 .Dd November 9, 2018
.Dt EDITLINE 3 .Dt EDITLINE 3
.Os .Os
.Sh NAME .Sh NAME
.Nm editline , .Nm editline ,
.Nm el_init , .Nm el_init ,
.Nm el_init_fd , .Nm el_init_fd ,
.Nm el_end , .Nm el_end ,
.Nm el_reset , .Nm el_reset ,
▲ Show 20 Lines • Show All 138 Lines • ▼ Show 20 Lines
.Pp .Pp
The The
.Nm .Nm
library respects the library respects the
.Ev LC_CTYPE .Ev LC_CTYPE
locale set by the application program and never uses locale set by the application program and never uses
.Xr setlocale 3 .Xr setlocale 3
to change the locale. to change the locale.
The only locales supported are UTF-8 and the default C or POSIX locale.
If any other locale is set, behaviour is undefined.
.Sh LINE EDITING FUNCTIONS .Sh LINE EDITING FUNCTIONS
The line editing functions use a common data structure, The line editing functions use a common data structure,
.Fa EditLine , .Fa EditLine ,
which is created by which is created by
.Fn el_init .Fn el_init
or or
.Fn el_init_fd .Fn el_init_fd
and freed by and freed by
▲ Show 20 Lines • Show All 782 Lines • Show Last 20 Lines
View Options

lib/libc/locale/wcstol.c

Show All 22 Lines
.\" SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS .\" SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
.\" INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN .\" INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
.\" CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) .\" CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
.\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
.\" POSSIBILITY OF SUCH DAMAGE. .\" POSSIBILITY OF SUCH DAMAGE.
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd April 28, 2017 .Dd November 9, 2018
.Dt EDITLINE 3 .Dt EDITLINE 3
.Os .Os
.Sh NAME .Sh NAME
.Nm editline , .Nm editline ,
.Nm el_init , .Nm el_init ,
.Nm el_init_fd , .Nm el_init_fd ,
.Nm el_end , .Nm el_end ,
.Nm el_reset , .Nm el_reset ,
▲ Show 20 Lines • Show All 138 Lines • ▼ Show 20 Lines
.Pp .Pp
The The
.Nm .Nm
library respects the library respects the
.Ev LC_CTYPE .Ev LC_CTYPE
locale set by the application program and never uses locale set by the application program and never uses
.Xr setlocale 3 .Xr setlocale 3
to change the locale. to change the locale.
The only locales supported are UTF-8 and the default C or POSIX locale.
If any other locale is set, behaviour is undefined.
.Sh LINE EDITING FUNCTIONS .Sh LINE EDITING FUNCTIONS
The line editing functions use a common data structure, The line editing functions use a common data structure,
.Fa EditLine , .Fa EditLine ,
which is created by which is created by
.Fn el_init .Fn el_init
or or
.Fn el_init_fd .Fn el_init_fd
and freed by and freed by
▲ Show 20 Lines • Show All 782 Lines • Show Last 20 Lines
View Options

lib/libc/locale/wcstoll.c

Show All 22 Lines
.\" SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS .\" SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
.\" INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN .\" INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
.\" CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) .\" CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
.\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
.\" POSSIBILITY OF SUCH DAMAGE. .\" POSSIBILITY OF SUCH DAMAGE.
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd April 28, 2017 .Dd November 9, 2018
.Dt EDITLINE 3 .Dt EDITLINE 3
.Os .Os
.Sh NAME .Sh NAME
.Nm editline , .Nm editline ,
.Nm el_init , .Nm el_init ,
.Nm el_init_fd , .Nm el_init_fd ,
.Nm el_end , .Nm el_end ,
.Nm el_reset , .Nm el_reset ,
▲ Show 20 Lines • Show All 138 Lines • ▼ Show 20 Lines
.Pp .Pp
The The
.Nm .Nm
library respects the library respects the
.Ev LC_CTYPE .Ev LC_CTYPE
locale set by the application program and never uses locale set by the application program and never uses
.Xr setlocale 3 .Xr setlocale 3
to change the locale. to change the locale.
The only locales supported are UTF-8 and the default C or POSIX locale.
If any other locale is set, behaviour is undefined.
.Sh LINE EDITING FUNCTIONS .Sh LINE EDITING FUNCTIONS
The line editing functions use a common data structure, The line editing functions use a common data structure,
.Fa EditLine , .Fa EditLine ,
which is created by which is created by
.Fn el_init .Fn el_init
or or
.Fn el_init_fd .Fn el_init_fd
and freed by and freed by
▲ Show 20 Lines • Show All 782 Lines • Show Last 20 Lines
View Options

lib/libc/locale/wcstoul.c

Loading...
View Options

lib/libc/locale/wcstoull.c

Loading...
View Options

lib/libc/locale/wcstoumax.c

Loading...