Paths

Table of Contentst

Differential D41236

tests: Add MAP_32BIT flag test
ClosedPublic
Actions

Authored by dchagin on Jul 30 2023, 6:30 PM.

Tags

None

Referenced Files

	F168998584: D41236.id125421.diff
	Mon, Aug 31, 2:31 AM

	F168995051: D41236.id125349.diff
	Mon, Aug 31, 2:20 AM

	F168983524: D41236.id125382.diff
	Mon, Aug 31, 1:29 AM

	F168982808: D41236.id125340.diff
	Mon, Aug 31, 1:26 AM

	F168961972: D41236.id.diff
	Sun, Aug 30, 11:35 PM

	F168947953: D41236.id125450.diff
	Sun, Aug 30, 10:03 PM

	F168942758: D41236.diff
	Sun, Aug 30, 9:18 PM

	Unknown Object (File)
	Sat, Aug 22, 10:02 AM

Subscribers

Details

Reviewers

kib
alc
markj

Commits

rG33d7da6ba2ab: tests: Add MAP_32BIT flag test
rG5a7e48dddfb5: tests: Add MAP_32BIT flag test

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 52925
Build 49816: arc lint + arc unit

Event Timeline

dchagin created this revision.Jul 30 2023, 6:30 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 30 2023, 6:30 PM

dchagin requested review of this revision.Jul 30 2023, 6:30 PM

Harbormaster completed remote builds in B52892: Diff 125340.Jul 30 2023, 6:30 PM

dchagin added reviewers: kib, alc.Jul 30 2023, 6:32 PM

I am curious, why don't you code this in pure C with ATF.

tests/sys/vm/mmap_map_32bit_helper.c
8	Not needed for the new files
34

kib added a reviewer: markj.Jul 30 2023, 9:54 PM

Done,
+ MAP_ANON

Harbormaster completed remote builds in B52893: Diff 125349.Jul 30 2023, 10:40 PM

In D41236#939212, @kib wrote:

I am curious, why don't you code this in pure C with ATF.

Mostly for the sake of running the test by hand, anyway the helper is needed

markj added inline comments.Jul 30 2023, 10:49 PM

tests/sys/vm/Makefile
14	Need to exclude 32-bit arm too.
tests/sys/vm/mmap_map_32bit_helper.c
15	Maybe add `_Static_assert(sizeof(vm_offset_t) >= 8);`
35
36
39	It's nice to check for errors from munmap() too.
41
45
46
tests/sys/vm/mmap_map_32bit_test.sh
17
28

Done, thanks. Tinderboxd

Harbormaster completed remote builds in B52907: Diff 125382.Jul 31 2023, 5:48 PM

dchagin marked 10 inline comments as done.Jul 31 2023, 5:51 PM

Seems ok to me, I left a few more notes. Thanks for adding tests.

tests/sys/vm/Makefile
13	A more general way to write it: .if ${MACHINE} != "i386" && ${MACHINE} != "arm" && (${MACHINE} != "powerpc" \|\| ${MACHINE_ARCH} != "powerpc")
tests/sys/vm/mmap_map_32bit_helper.c
40
50

This revision is now accepted and ready to land.Jul 31 2023, 7:34 PM

kib added inline comments.Aug 1 2023, 3:08 AM

tests/sys/vm/mmap_map_32bit_helper.c
8	You do not need to explicitly include sys/cdefs.h.
36	Shouldn't it be s32 + pagesize > MAP_32BIT_MAX_ADDR? At least to allow easier change to the mapping size.

Seems done, thanks.

This revision now requires review to proceed.Aug 1 2023, 3:25 PM

Harbormaster completed remote builds in B52925: Diff 125421.Aug 1 2023, 3:26 PM

dchagin marked 5 inline comments as done.Aug 1 2023, 3:26 PM

dchagin added inline comments.

tests/sys/vm/mmap_map_32bit_helper.c
36	I agree, thank you

kib accepted this revision.Aug 1 2023, 3:59 PM

This revision is now accepted and ready to land.Aug 1 2023, 3:59 PM

Closed by commit rG5a7e48dddfb5: tests: Add MAP_32BIT flag test (authored by dchagin). · Explain WhyAug 1 2023, 8:24 PM

This revision was automatically updated to reflect the committed changes.

dchagin marked an inline comment as done.

dchagin added a commit: rG5a7e48dddfb5: tests: Add MAP_32BIT flag test.

dchagin added a commit: rG33d7da6ba2ab: tests: Add MAP_32BIT flag test.Aug 27 2023, 7:33 AM

Revision Contents
Changeset List

Path

Size

tests/

sys/

vm/

8 lines

mmap_map_32bit_helper.c

51 lines

mmap_map_32bit_test.sh

37 lines

Diff 125421

tests/sys/vm/Makefile

Loading...

tests/sys/vm/mmap_map_32bit_helper.c

Loading...

tests/sys/vm/mmap_map_32bit_test.sh

Loading...