Page MenuHomeFreeBSD
Differential D41034

Obsoletefiles.inc: A few OpenSSL 3 cleanups.
ClosedPublic
Actions

Authored by jhb on Jul 13 2023, 11:50 PM.
Tags
None
Referenced Files
F93761412: D41034.id124649.diff
Thu, Sep 12, 7:50 AM
F93760499: D41034.id124682.diff
Thu, Sep 12, 7:34 AM
Unknown Object (File)
Tue, Sep 10, 8:59 PM
Unknown Object (File)
Mon, Sep 9, 2:00 AM
Unknown Object (File)
Sun, Sep 8, 12:04 AM
Unknown Object (File)
Sat, Sep 7, 9:22 AM
Unknown Object (File)
Thu, Sep 5, 12:35 PM
Unknown Object (File)
Tue, Aug 20, 10:57 AM
View All 20 Files
Subscribers
imp

Details

Reviewers
emaste
khorben_defora.org
Commits
rGa248abb55a51: Obsoletefiles.inc: A few OpenSSL 3 cleanups.
Summary
  • Treat old engine DSOs from OpenSSL 1.1.1 as OLD_LIBS, not OLD_FILES. These should only be deleted by make delete-old-libs similar to how PAM modules are treated.
  • Add /usr/lib32/engines to OLD_DIRS. lib32 automation does not apply to OLD_DIRS.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52639
Build 49530: arc lint + arc unit

Event Timeline

jhb created this revision.Jul 13 2023, 11:50 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 13 2023, 11:50 PM
jhb requested review of this revision.Jul 13 2023, 11:50 PM
Harbormaster completed remote builds in B52639: Diff 124649.Jul 13 2023, 11:50 PM
jhb added a reviewer: khorben_defora.org.Jul 14 2023, 12:15 AM
khorben_defora.org added a comment.Jul 14 2023, 1:34 PM

Thanks for the patch and explanation!
Did you not mean OLD_LIBS instead of OLD_DIRS for capi.so and padlock.so inside the patch itself?

jhb added a comment.Jul 14 2023, 3:25 PM

Oh dear, yes.

jhb updated this revision to Diff 124682.Jul 14 2023, 4:30 PM

Use OLD_LIBS for real

Harbormaster completed remote builds in B52652: Diff 124682.Jul 14 2023, 4:30 PM
khorben_defora.org accepted this revision.Jul 14 2023, 5:16 PM

LGTM!

This revision is now accepted and ready to land.Jul 14 2023, 5:16 PM
Closed by commit rGa248abb55a51: Obsoletefiles.inc: A few OpenSSL 3 cleanups. (authored by jhb). · Explain WhyJul 14 2023, 5:27 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGa248abb55a51: Obsoletefiles.inc: A few OpenSSL 3 cleanups..

Revision Contents
Changeset List

PathSize
5 lines

Diff 124649

View Options

ObsoleteFiles.inc

Loading...