Page MenuHomeFreeBSD
Differential D31007

depend-cleanup: Add verbose (-v) and pretend/dry-run (-n) flags
ClosedPublic
Actions

Authored by jrtc27 on Jul 3 2021, 2:38 AM.
Tags
None
Referenced Files
F101743183: D31007.id124469.diff
Sun, Nov 3, 5:18 AM
F101743129: D31007.id91690.diff
Sun, Nov 3, 5:17 AM
Unknown Object (File)
Sep 17 2024, 8:37 PM
Unknown Object (File)
Sep 16 2024, 5:33 PM
Unknown Object (File)
Sep 16 2024, 5:33 PM
Unknown Object (File)
Sep 16 2024, 5:33 PM
Unknown Object (File)
Sep 11 2024, 4:41 PM
Unknown Object (File)
Sep 11 2024, 4:41 PM
View All 63 Files
Subscribers
imp

Details

Reviewers
brooks
emaste
imp
Commits
rG1ec7cb1b5d18: depend-cleanup: Add verbose (-v) and pretend/dry-run (-n) flags
Summary

These are useful for testing new additions to the script. Whilst here,
harden the script a little and improve error messages.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrtc27 created this revision.Jul 3 2021, 2:38 AM
Herald added a subscriber: imp. · View Herald TranscriptJul 3 2021, 2:38 AM
jrtc27 requested review of this revision.Jul 3 2021, 2:38 AM
Harbormaster completed remote builds in B40249: Diff 91690.Jul 3 2021, 2:38 AM
imp accepted this revision.Jul 10 2023, 11:12 PM

Conditional on rebasing to something newer :)

This revision is now accepted and ready to land.Jul 10 2023, 11:12 PM
jrtc27 updated this revision to Diff 124465.Jul 10 2023, 11:20 PM

Rebase

This revision now requires review to proceed.Jul 10 2023, 11:20 PM
Harbormaster completed remote builds in B52553: Diff 124465.Jul 10 2023, 11:20 PM
jrtc27 updated this revision to Diff 124466.Jul 10 2023, 11:28 PM

Handle MACHINE_ARCH being empty during bootstrap-tools use

Harbormaster completed remote builds in B52554: Diff 124466.Jul 10 2023, 11:28 PM
imp added a comment.Jul 10 2023, 11:31 PM
In D31007#932469, @jrtc27 wrote:

Handle MACHINE_ARCH being empty during bootstrap-tools use

When can it be empty?

jrtc27 added a comment.Jul 10 2023, 11:38 PM
In D31007#932472, @imp wrote:
In D31007#932469, @jrtc27 wrote:

Handle MACHINE_ARCH being empty during bootstrap-tools use

When can it be empty?

We run the script twice. The first time is during bootstrap-tools for obj-tools and there it's under BMAKE(ENV) which doesn't do any TARGET/MACHINE(_ARCH) assignment (just leaves them as they are for the parent, which may mean re-inferring). The second time is the one for the real OBJTOP where it's run under WMAKE(ENV) and picks up TARGET(_ARCH)=MACHINE(_ARCH) from CROSSENV.

Probably _cleanobj_fast_depend_hack should just do env MACHINE=${MACHINE} MACHINE_ARCH=${MACHINE_ARCH} instead, to be honest.

jrtc27 updated this revision to Diff 124469.Jul 10 2023, 11:51 PM

Rebase atop D40968

Harbormaster completed remote builds in B52557: Diff 124469.Jul 10 2023, 11:51 PM
jrtc27 added a parent revision: D40968: Make sure MACHINE(_ARCH) are exported for depend-cleanup.sh.Jul 10 2023, 11:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 11 2023, 12:53 AM
Closed by commit rG1ec7cb1b5d18: depend-cleanup: Add verbose (-v) and pretend/dry-run (-n) flags (authored by jrtc27). · Explain Why
This revision was automatically updated to reflect the committed changes.
jrtc27 added a commit: rG1ec7cb1b5d18: depend-cleanup: Add verbose (-v) and pretend/dry-run (-n) flags.
jrtc27 mentioned this in D40968: Make sure MACHINE(_ARCH) are exported for depend-cleanup.sh.Jul 11 2023, 1:00 AM

Revision Contents
Changeset List

PathSize
tools/
build/
82 lines

Diff 124472

View Options

tools/build/depend-cleanup.sh

Loading...