Allows running socket_afinet regression tests in parallel
ClosedPublic
Actions

Authored by olivier on Jul 3 2023, 4:44 PM.

Details

Reviewers

markj
melifaro

Commits

rG150d8ca9f3ba: socket afinet tests: using dynamic ports instead of the same static port

Summary

They all are using the same port for binding server, so conflicting when running in parallel.

Test Plan

Before:
Set parallelism=8 in /etc/kyua/kyua.conf, and run it.
It will fails once reach socket_afinet_stream_reconnect tests

After:
No more failure

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olivier created this revision.Jul 3 2023, 4:44 PM

Herald added subscribers: glebius, melifaro, asomers. · View Herald TranscriptJul 3 2023, 4:44 PM

olivier requested review of this revision.Jul 3 2023, 4:44 PM

olivier retitled this revision from Allows running /socket_afinet regression tests in parallel to Allows running socket_afinet regression tests in parallel.

melifaro accepted this revision.Jul 3 2023, 6:48 PM

This revision is now accepted and ready to land.Jul 3 2023, 6:48 PM

Ok, but this is still fragile. It assumes that nothing else in the entire test suite will bind to ports 6667-6669. Probably these tests should specify sin.sin_port = 0 and then use getsockname() to figure out which port was assigned.