Page MenuHomeFreeBSD
Differential D40121

LinuxKPI: implement get_random_u32_inclusive()
ClosedPublic
Actions

Authored by bz on May 16 2023, 9:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 1, 1:13 AM
Unknown Object (File)
Sat, Jan 31, 11:44 PM
Unknown Object (File)
Sat, Jan 31, 12:33 AM
Unknown Object (File)
Wed, Jan 28, 10:24 PM
Unknown Object (File)
Fri, Jan 23, 12:43 AM
Unknown Object (File)
Fri, Jan 23, 12:33 AM
Unknown Object (File)
Fri, Jan 23, 12:16 AM
Unknown Object (File)
Wed, Jan 14, 6:48 PM
View All Files
Subscribers
emaste
• hselasky
imp

Details

Reviewers
cperciva
dwmalone
Group Reviewers
linuxkpi
Commits
rG1dcd1a539275: LinuxKPI: implement get_random_u32_inclusive()
Summary

Attempt of an implementation of get_random_u32_inclusive().
This is needed by an update for wireless drivers.

Sponsored by: The FreeBSD Foundation
MFC after: 10 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 52368
Build 49259: arc lint + arc unit

Event Timeline

bz created this revision.May 16 2023, 9:08 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptMay 16 2023, 9:08 PM
bz requested review of this revision.May 16 2023, 9:08 PM
Harbormaster completed remote builds in B51513: Diff 122013.May 16 2023, 9:09 PM
emaste added inline comments.May 16 2023, 11:09 PM
sys/compat/linuxkpi/common/include/linux/random.h
62

low and top seem like an odd pair - I'd think low and high, bottom and top, or floor and ceil.

bz updated this revision to Diff 122018.May 16 2023, 11:49 PM

Change function argument names to floor/ceil as suggested by @emaste.

Harbormaster completed remote builds in B51517: Diff 122018.May 16 2023, 11:49 PM
bz marked an inline comment as done.Jun 8 2023, 6:09 PM
bz added a comment.Jun 8 2023, 6:18 PM

Anyone?

• hselasky added a subscriber: • hselasky.Jun 9 2023, 12:31 PM
• hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/random.h
70

Is there a reason for the while loop? Is zero not valid for "x >> 32" ?

emaste added a comment.Jun 9 2023, 12:47 PM

See also https://arxiv.org/pdf/1805.10941.pdf

• hselasky added a comment.Jun 9 2023, 12:51 PM

Maybe add:
MPASS(ceil >= floor);

Maybe add a comment showing the reference to the .PDF document explaining the formula ...

What do you think?

sys/compat/linuxkpi/common/include/linux/random.h
70

@emaste : Thanks for the link!

bz updated this revision to Diff 124042.Jun 30 2023, 8:18 PM

Address review comments.

@emaste, do you think this is okay now?

Harbormaster completed remote builds in B52368: Diff 124042.Jun 30 2023, 8:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 7 2023, 1:00 AM
Closed by commit rG1dcd1a539275: LinuxKPI: implement get_random_u32_inclusive() (authored by bz). · Explain Why
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG1dcd1a539275: LinuxKPI: implement get_random_u32_inclusive().

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
30 lines

Diff 124042

View Options

sys/compat/linuxkpi/common/include/linux/random.h

Loading...