User Details
User Details
- User Since
- Feb 4 2016, 9:41 AM (429 w, 2 h)
Aug 17 2023
Aug 17 2023
Aug 16 2023
Aug 16 2023
dwmalone added a comment to D40120: LinuxKPI: implement mul_u64_u64_div_u64().
Looks sensible to me. Minor observations:
- It will blow up with a division by zero if z = 0, however, that's probably the correct behaviour.
- The two checks for overflow are clever - if we overflow, then we have definitely exceed our invariant, and so need to do the reduce step.
- I've suggested recording one extra invariant above.
- I've run a few different versions of this test code, and it has always produced the correct answers, so I think it is working fine.
dwmalone added a comment to D40120: LinuxKPI: implement mul_u64_u64_div_u64().
Will have a look today.
Dec 12 2021
Dec 12 2021
This looks good to me - including a random hashseed seems like a great idea. I guess someday it might be neat to hash the fport and lport values, rather than xor them, but that should wait for another day if this has already been running in Netfilx.
Jul 29 2021
Jul 29 2021
dwmalone committed rGfd309107e9dc: Minor language improvements. Note that they can't be changed (authored by dwmalone).
Minor language improvements. Note that they can't be changed
May 25 2021
May 25 2021
Also looks good to me. Slightly pedantic suggestions:
Dec 13 2020
Dec 13 2020
Move myself from contrib to staff.
Add myself.
dwmalone committed R9:1d569acd677c: Add BUGI entry (BSD Users Group Ireland). (authored by dwmalone).
Add BUGI entry (BSD Users Group Ireland).
dwmalone committed R9:a3eceefc4820: Add cvsup.ie.freebsd.org as a cvs mirror. We're updating once an hour (authored by dwmalone).
Add cvsup.ie.freebsd.org as a cvs mirror. We're updating once an hour
dwmalone committed R9:18e8bc430305: Bump __FreeBSD_version after change in ABI for discriptor and creds passing (authored by dwmalone).
Bump __FreeBSD_version after change in ABI for discriptor and creds passing
Add my pgp key.
Add ftp3.ie.freebsd.org
dwmalone committed R9:982b7116cc6e: Add a comment to aid the collection of certain canned meat products. (authored by dwmalone).
Add a comment to aid the collection of certain canned meat products.
dwmalone committed R9:5aa6804ebec2: The text for the on-disk directory indexing idea described the (authored by dwmalone).
The text for the on-disk directory indexing idea described the
Jan 28 2020
Jan 28 2020
dwmalone committed rS357204: Add some missing articles..
Add some missing articles.
Aug 4 2016
Aug 4 2016
Mar 6 2016
Mar 6 2016
dwmalone committed rS296431: Merge 296424 from stable/10 - contains the following changes to -current:.
Merge 296424 from stable/10 - contains the following changes to -current:
Feb 23 2016
Feb 23 2016
dwmalone committed rS295925: Following revision r295924, the changes to a db file should be fsynced.
Following revision r295924, the changes to a db file should be fsynced
If we close or sync a hash-based db file, make sure to call fsync to
Feb 18 2016
Feb 18 2016
dwmalone added a comment to D5186: pwd_mkdb opens files with O_SYNC instead of calling fsync.
Great - I'll commit it in the next day or two, and ask for permission to MFC.
Feb 4 2016
Feb 4 2016
dwmalone retitled D5186: pwd_mkdb opens files with O_SYNC instead of calling fsync from to pwd_mkdb opens files with O_SYNC instead of calling fsync.