Differential D40522

camcontrol: Simplfiy 12-byte retry logic in defects command
ClosedPublic
Actions

Authored by imp on Jun 13 2023, 9:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 17, 2:39 AM

	Unknown Object (File)
	Sat, Oct 17, 2:26 AM

	Unknown Object (File)
	Sat, Oct 17, 1:55 AM

	Unknown Object (File)
	Sat, Oct 17, 1:28 AM

	Unknown Object (File)
	Tue, Sep 22, 4:04 PM

	Unknown Object (File)
	Sep 18 2026, 9:41 PM

	Unknown Object (File)
	Sep 16 2026, 11:56 AM

	Unknown Object (File)
	Aug 30 2026, 2:49 PM

Subscribers

None

Details

Reviewers

ken
mav

Commits

rG97e24c386868: camcontrol: Simplfiy 12-byte retry logic in defects command

Summary

We always start out using the 10-byte version of READ DEFECT DATA, and
then switch to 12-byte when necessary due to errors or data length
requirements. We always need to get the length again when we do this,
and we're always going to be using 12-byte commands from that point
forward. Simplify the logic a bit based on this observation.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Jun 13 2023, 9:25 PM

imp created this revision.

Harbormaster completed remote builds in B52031: Diff 123175.Jun 13 2023, 9:25 PM

imp added a parent revision: D40521: camcontrol: Convert int used as booleans to bools in defects command.Jun 13 2023, 9:25 PM

imp added a child revision: D40523: camcontrol: No need to set CAM_ARG_[PG]LIST in defects.

imp added reviewers: ken, mav.Jun 13 2023, 9:29 PM

mav accepted this revision.Jun 15 2023, 2:13 PM

This revision is now accepted and ready to land.Jun 15 2023, 2:13 PM

Closed by commit rG97e24c386868: camcontrol: Simplfiy 12-byte retry logic in defects command (authored by imp). · Explain WhyJun 19 2023, 8:48 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG97e24c386868: camcontrol: Simplfiy 12-byte retry logic in defects command.

Revision Contents
Changeset List

Path

Size

sbin/

camcontrol/

31 lines

Diff 123450

sbin/camcontrol/camcontrol.c

Loading...