Paths

Table of Contentst

Differential D4943

libc/libstand for RISC-V
ClosedPublic
Actions

Authored by br on Jan 14 2016, 5:06 PM.

Tags

None

Referenced Files

	F103254487: D4943.id.diff
	Fri, Nov 22, 4:39 PM

	Unknown Object (File)
	Thu, Nov 21, 10:45 AM

	Unknown Object (File)
	Wed, Nov 20, 4:40 PM

	Unknown Object (File)
	Wed, Nov 20, 4:22 AM

	Unknown Object (File)
	Thu, Nov 14, 8:53 PM

	Unknown Object (File)
	Sun, Nov 10, 1:46 PM

	Unknown Object (File)
	Sun, Nov 10, 1:46 PM

	Unknown Object (File)
	Thu, Nov 7, 6:57 PM

Subscribers

Details

Reviewers

kib
emaste
andrew

Commits

rS294227: Bring in initial libc and libstand support for RISC-V.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

br updated this revision to Diff 12321.Jan 14 2016, 5:06 PM

br retitled this revision from to libc/libstand for RISC-V.

br updated this object.

br edited the test plan for this revision. (Show Details)

br added reviewers: andrew, emaste.

Replace "This software..." with "Portions of this software..."

andrew added a reviewer: kib.Jan 14 2016, 9:37 PM

andrew added inline comments.

lib/libc/riscv/_fpmath.h
39	I should check the packing :-)
lib/libc/xdr/xdr_float.c
64–68	I've been wondering why this exists, all architectures we support (and some we don't) are listed here.

kib added inline comments.Jan 14 2016, 10:22 PM

lib/libc/xdr/xdr_float.c
64–68	I suspect that ppc64 isn't. The code was written by Sun and then not sanitized.

andrew added a subscriber: jhibbits.Jan 14 2016, 10:38 PM

andrew added inline comments.

lib/libc/xdr/xdr_float.c
64–68	I thought (and @jhibbits confirmed) that `__ppc__` was defined when building for ppc64.

emaste added inline comments.Jan 15 2016, 2:29 PM

lib/libc/xdr/xdr_float.c
64–68	Agree, the `#if` should just be removed.
lib/libstand/Makefile
78–81	perhaps combine aarch64 and riscv case into .PATH ${LIBC_SRC}/${MACHINE_CPUARCH}/gen

arith.h and gd_qnan.h regenerated;
architectures check in lib/libc/xdr/xdr_float.c removed;
aarch64 and riscv cases in libstand/Makefile combined.

andrew accepted this revision.Jan 15 2016, 6:11 PM

andrew edited edge metadata.

andrew added inline comments.

lib/libc/xdr/xdr_float.c
63–69	I've built a similar change where I also removed all the Vax code. Without it this file is much simpler. I'm happy with just removing the `#if` for now.

This revision is now accepted and ready to land.Jan 15 2016, 6:11 PM

Closed by commit rS294227: Bring in initial libc and libstand support for RISC-V. (authored by br). · Explain WhyJan 17 2016, 3:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

libc/

3 lines

gen/

9 lines

riscv/

8 lines

68 lines

42 lines

72 lines

19 lines

21 lines

gen/

13 lines

43 lines

50 lines

151 lines

41 lines

71 lines

14 lines

91 lines

173 lines

57 lines

sys/

25 lines

79 lines

50 lines

57 lines

77 lines

40 lines

40 lines

40 lines

51 lines

xdr/

2 lines

libstand/

4 lines

Diff 12321

lib/libc/Makefile

Loading...

lib/libc/gen/tls.c

Loading...

lib/libc/riscv/Makefile.inc

Loading...

lib/libc/riscv/SYS.h

Loading...

lib/libc/riscv/Symbol.map

Loading...

lib/libc/riscv/_fpmath.h

Loading...

lib/libc/riscv/arith.h

Loading...

lib/libc/riscv/gd_qnan.h

Loading...

lib/libc/riscv/gen/Makefile.inc

Loading...

lib/libc/riscv/gen/_ctx_start.S

Loading...

lib/libc/riscv/gen/_set_tp.c

Loading...

lib/libc/riscv/gen/_setjmp.S

Loading...

lib/libc/riscv/gen/fabs.S

Loading...

lib/libc/riscv/gen/flt_rounds.c

Loading...

lib/libc/riscv/gen/infinity.c

Loading...

lib/libc/riscv/gen/makecontext.c

Loading...

lib/libc/riscv/gen/setjmp.S

Loading...

lib/libc/riscv/gen/sigsetjmp.S

Loading...

lib/libc/riscv/sys/Makefile.inc

Loading...

lib/libc/riscv/sys/brk.S

Loading...

lib/libc/riscv/sys/cerror.S

Loading...

lib/libc/riscv/sys/pipe.S

Loading...

lib/libc/riscv/sys/sbrk.S

Loading...

lib/libc/riscv/sys/shmat.S

Loading...

lib/libc/riscv/sys/sigreturn.S

Loading...

lib/libc/riscv/sys/syscall.S

Loading...

lib/libc/riscv/sys/vfork.S

Loading...

lib/libc/xdr/xdr_float.c

Loading...

lib/libstand/Makefile

Loading...