Page MenuHomeFreeBSD

libc/libstand for RISC-V
ClosedPublic

Authored by br on Jan 14 2016, 5:06 PM.
Tags
None
Referenced Files
F103501417: D4943.diff
Mon, Nov 25, 7:48 PM
Unknown Object (File)
Mon, Nov 25, 3:32 AM
Unknown Object (File)
Sat, Nov 23, 5:19 PM
Unknown Object (File)
Fri, Nov 22, 11:15 PM
Unknown Object (File)
Fri, Nov 22, 4:39 PM
Unknown Object (File)
Thu, Nov 21, 10:45 AM
Unknown Object (File)
Wed, Nov 20, 4:40 PM
Unknown Object (File)
Wed, Nov 20, 4:22 AM
Subscribers

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br retitled this revision from to libc/libstand for RISC-V.
br updated this object.
br edited the test plan for this revision. (Show Details)
br added reviewers: andrew, emaste.

Replace "This software..." with "Portions of this software..."

andrew added inline comments.
lib/libc/riscv/_fpmath.h
39

I should check the packing :-)

lib/libc/xdr/xdr_float.c
63–64

I've been wondering why this exists, all architectures we support (and some we don't) are listed here.

lib/libc/xdr/xdr_float.c
63–64

I suspect that ppc64 isn't. The code was written by Sun and then not sanitized.

andrew added inline comments.
lib/libc/xdr/xdr_float.c
63–64

I thought (and @jhibbits confirmed) that __ppc__ was defined when building for ppc64.

lib/libc/xdr/xdr_float.c
63–64

Agree, the #if should just be removed.

lib/libstand/Makefile
78–81

perhaps combine aarch64 and riscv case into

.PATH ${LIBC_SRC}/${MACHINE_CPUARCH}/gen
  • arith.h and gd_qnan.h regenerated;
  • architectures check in lib/libc/xdr/xdr_float.c removed;
  • aarch64 and riscv cases in libstand/Makefile combined.
andrew edited edge metadata.
andrew added inline comments.
lib/libc/xdr/xdr_float.c
63–64

I've built a similar change where I also removed all the Vax code. Without it this file is much simpler. I'm happy with just removing the #if for now.

This revision is now accepted and ready to land.Jan 15 2016, 6:11 PM
This revision was automatically updated to reflect the committed changes.