camcontrol: In defects make -S actually imply 12-byte command
ClosedPublic
Actions

Authored by imp on Jun 13 2023, 9:26 PM.

Details

Reviewers

ken
mav

Commits

rGe8cdabb4e135: camcontrol: In defects make -S actually imply 12-byte command

Summary

camcontrol(8) says that -S to start at a different offset implies that
we're using the 12 byte command. But really, we're using the 10-byte
command. Fix this by setting use_12byte for -S.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52035
Build 48926: arc lint + arc unit

Event Timeline

imp requested review of this revision.Jun 13 2023, 9:26 PM

imp created this revision.

Harbormaster completed remote builds in B52035: Diff 123179.Jun 13 2023, 9:26 PM

imp added a parent revision: D40525: camcontrol: Add support for -r XX to set reserved bits in defects.Jun 13 2023, 9:26 PM

imp added a child revision: D40527: cam: Remove duplicate definition for READ_DEFECT_DATA_10.

imp added reviewers: ken, mav.Jun 13 2023, 9:27 PM

mav accepted this revision.Jun 15 2023, 2:04 PM

This revision is now accepted and ready to land.Jun 15 2023, 2:04 PM

Closed by commit rGe8cdabb4e135: camcontrol: In defects make -S actually imply 12-byte command (authored by imp). · Explain WhyJun 19 2023, 8:49 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGe8cdabb4e135: camcontrol: In defects make -S actually imply 12-byte command.

Revision Contents
Changeset List

Path

Size

sbin/

camcontrol/

camcontrol.c

1 line

Diff 123179

View Options

sbin/camcontrol/camcontrol.c

camcontrol: In defects make -S actually imply 12-byte commandClosedPublicActions