Page MenuHomeFreeBSD
Differential D40467

ld(1): Correctly define .init_array and .fini_array for all platforms.
AbandonedPublic
Actions

Authored by zlei on Jun 7 2023, 3:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 29, 3:38 PM
Unknown Object (File)
Sun, Jun 29, 6:47 AM
Unknown Object (File)
Thu, Jun 26, 4:07 AM
Unknown Object (File)
Mon, Jun 23, 10:38 PM
Unknown Object (File)
Mon, Jun 23, 5:01 PM
Unknown Object (File)
Sun, Jun 22, 7:35 AM
Unknown Object (File)
Fri, Jun 20, 2:48 AM
Unknown Object (File)
Fri, Jun 6, 10:39 PM
View All 87 Files
Subscribers
andrew
arichardson
emaste
imp
zlei

Details

Reviewers
emaste
arichardson
andrew
• hselasky
Commits
rG3e76d05231b0: kernel: Add defination of .init_array and .fini_array for all other platforms
rGe15b5ba77d69: kernel: Fix defining of .init_array and .fini_array sections
Summary

The constructor and destructor section names can have a priority
suffixed, as a decimal number.

Unless the ldscript is instructed to sort these sections
into a single one, this feature does not work as expected.

MFC after: 1 week
Sponsored by: NVIDIA Networking

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

• hselasky created this revision.Jun 7 2023, 3:14 PM
Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptJun 7 2023, 3:14 PM
• hselasky requested review of this revision.Jun 7 2023, 3:14 PM
• hselasky mentioned this in D40463: kernel: Use the compiler supported constructor and destructor attributes to register sysinits..Jun 7 2023, 3:16 PM
• hselasky added a reviewer: emaste.

@emaste : You added something similar a while back for amd64. Adding you for review.

arichardson requested changes to this revision.Jun 7 2023, 4:18 PM
arichardson added a subscriber: arichardson.

This will sort by name not priority. Ld.lld will sort by priority automatically if you omit init_array from the linker script but for bfd you need SORT_BY_INIT_PRIORITY

This revision now requires changes to proceed.Jun 7 2023, 4:18 PM
emaste added a comment.Jun 7 2023, 5:45 PM

Looks like these are in amd64 via rG:8ba66bb849129

• hselasky updated this revision to Diff 122961.Jun 7 2023, 10:57 PM

@arichardson : Use SORT_BY_INIT_PRIORITY()

Should .ctors and .dtors use the same?

zlei mentioned this in D45194: kernel: Fix defining of .init_array and .fini_array sections.May 14 2024, 4:24 AM
zlei added a subscriber: zlei.May 14 2024, 4:27 AM

Split the FIX for sorting input sections to D45194 .

Herald added a reviewer: andrew. · View Herald TranscriptMay 14 2024, 4:27 AM
Herald added a reviewer: andrew. · View Herald Transcript
zlei mentioned this in D45214: kernel: Add defination of .init_array and .fini_array for all other platforms.May 16 2024, 7:54 AM
zlei added a comment.May 16 2024, 7:57 AM

I tried to Update Diff but failed. Split the definition for other platforms to D45214 .

zlei mentioned this in rGe15b5ba77d69: kernel: Fix defining of .init_array and .fini_array sections.Sep 2 2024, 4:30 AM
zlei mentioned this in rG3e76d05231b0: kernel: Add defination of .init_array and .fini_array for all other platforms.
zlei commandeered this revision.Sep 2 2024, 8:58 AM
zlei abandoned this revision.
zlei added a reviewer: • hselasky.

Landed as e15b5ba77d69 and 3e76d05231b0 .

emaste added commits: rGe15b5ba77d69: kernel: Fix defining of .init_array and .fini_array sections, rG3e76d05231b0: kernel: Add defination of .init_array and .fini_array for all other platforms.Sep 2 2024, 3:40 PM
zlei mentioned this in rG1d94490aee5c: kernel: Fix defining of .init_array and .fini_array sections.Sep 22 2024, 2:49 PM
zlei mentioned this in rGbb5f70161454: kernel: Add defination of .init_array and .fini_array for all other platforms.
zlei mentioned this in rG87841ead405f: kernel: Fix defining of .init_array and .fini_array sections.Sep 24 2024, 4:16 AM

Revision Contents
Changeset List

Diff 122961

View Options

sys/conf/ldscript.amd64

Loading...
View Options

sys/conf/ldscript.arm

Loading...
View Options

sys/conf/ldscript.arm64

Loading...
View Options

sys/conf/ldscript.i386

Loading...
View Options

sys/conf/ldscript.powerpc

Loading...
View Options

sys/conf/ldscript.powerpc64

Loading...
View Options

sys/conf/ldscript.powerpc64le

Loading...
View Options

sys/conf/ldscript.powerpcspe

Loading...
View Options

sys/conf/ldscript.riscv

Loading...