Page MenuHomeFreeBSD
Differential D40309

avx_sig: Adapt avx_sig test for Aarch64
ClosedPublic
Actions

Authored by dchagin on May 28 2023, 12:27 PM.
Tags
Referenced Files
Unknown Object (File)
Mar 12 2025, 12:50 AM
Unknown Object (File)
Feb 21 2025, 2:09 PM
Unknown Object (File)
Feb 19 2025, 12:59 PM
Unknown Object (File)
Feb 5 2025, 2:32 AM
Unknown Object (File)
Jan 27 2025, 12:32 PM
Unknown Object (File)
Jan 26 2025, 7:50 PM
Unknown Object (File)
Nov 28 2024, 11:45 PM
Unknown Object (File)
Nov 28 2024, 8:56 AM
View All 54 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
kib
Group Reviewers
arm64
Commits
rG4f2c2a122c6f: avx_sig: Adapt avx_sig test for Aarch64

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51750
Build 48641: arc lint + arc unit

Event Timeline

dchagin created this revision.May 28 2023, 12:27 PM
Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptMay 28 2023, 12:27 PM
dchagin requested review of this revision.May 28 2023, 12:27 PM
Harbormaster completed remote builds in B51744: Diff 122533.May 28 2023, 12:27 PM
dchagin added reviewers: kib, arm64.May 28 2023, 12:29 PM
dchagin added a project: arm64.
dchagin added a comment.May 28 2023, 12:31 PM

For now test succeed on Linux, fails on native and in the Linuxulator

kib added a comment.May 28 2023, 4:56 PM

There are no XMM regs on aarch64.

dchagin added a comment.May 28 2023, 5:39 PM
In D40309#917796, @kib wrote:

There are no XMM regs on aarch64.

I know, it was a quick fix to test some changes,
I propose to move inlined asm code to a separate file and rename xmm names to more general names.

Btw, under Linuxulator test works, I forgot to chroot before testing,
so only native fails.

dchagin updated this revision to Diff 122545.May 28 2023, 10:35 PM

Rebase to D40312

Harbormaster completed remote builds in B51750: Diff 122545.May 28 2023, 10:35 PM
kib accepted this revision.May 29 2023, 9:54 AM
This revision is now accepted and ready to land.May 29 2023, 9:54 AM
Closed by commit rG4f2c2a122c6f: avx_sig: Adapt avx_sig test for Aarch64 (authored by dchagin). · Explain WhyMay 30 2023, 8:20 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG4f2c2a122c6f: avx_sig: Adapt avx_sig test for Aarch64.

Revision Contents
Changeset List

PathSize
tools/
test/
avx_sig/
3 lines
8 lines
55 lines

Diff 122545

View Options

tools/test/avx_sig/Makefile

Show First 20 Lines • Show All 1,401 Lines • ▼ Show 20 Linesdointr(unsigned int interval, int reps)
xo_close_container("interrupt-statistics"); xo_close_container("interrupt-statistics");
} }
static void static void
domemstat_malloc(void) domemstat_malloc(void)
{ {
struct memory_type_list *mtlp; struct memory_type_list *mtlp;
struct memory_type *mtp; struct memory_type *mtp;
int error, first, i; size_t i, zones;
int error, first;
mtlp = memstat_mtl_alloc(); mtlp = memstat_mtl_alloc();
if (mtlp == NULL) { if (mtlp == NULL) {
xo_warn("memstat_mtl_alloc"); xo_warn("memstat_mtl_alloc");
return; return;
} }
if (kd == NULL) { if (kd == NULL) {
if (memstat_sysctl_malloc(mtlp, 0) < 0) { if (memstat_sysctl_malloc(mtlp, 0) < 0) {
xo_warnx("memstat_sysctl_malloc: %s", xo_warnx("memstat_sysctl_malloc: %s",
memstat_strerror(memstat_mtl_geterror(mtlp))); memstat_strerror(memstat_mtl_geterror(mtlp)));
return; return;
} }
markjUnsubmitted
Not Done
Inline Actions

This won't work if running against a vmcore.

markj: This won't work if running against a vmcore.
} else { } else {
if (memstat_kvm_malloc(mtlp, kd) < 0) { if (memstat_kvm_malloc(mtlp, kd) < 0) {
error = memstat_mtl_geterror(mtlp); error = memstat_mtl_geterror(mtlp);
if (error == MEMSTAT_ERROR_KVM) if (error == MEMSTAT_ERROR_KVM)
xo_warnx("memstat_kvm_malloc: %s", xo_warnx("memstat_kvm_malloc: %s",
kvm_geterr(kd)); kvm_geterr(kd));
else else
xo_warnx("memstat_kvm_malloc: %s", xo_warnx("memstat_kvm_malloc: %s",
memstat_strerror(error)); memstat_strerror(error));
} }
} }
xo_open_container("malloc-statistics"); xo_open_container("malloc-statistics");
xo_emit("{T:/%13s} {T:/%5s} {T:/%6s} {T:/%7s} {T:/%8s} {T:Size(s)}\n", xo_emit("{T:/%13s} {T:/%5s} {T:/%6s} {T:/%7s} {T:/%8s} {T:Size(s)}\n",
"Type", "InUse", "MemUse", "HighUse", "Requests"); "Type", "InUse", "MemUse", "HighUse", "Requests");
xo_open_list("memory"); xo_open_list("memory");
zones = memstat_malloc_zone_get_count();
for (mtp = memstat_mtl_first(mtlp); mtp != NULL; for (mtp = memstat_mtl_first(mtlp); mtp != NULL;
mtp = memstat_mtl_next(mtp)) { mtp = memstat_mtl_next(mtp)) {
if (memstat_get_numallocs(mtp) == 0 && if (memstat_get_numallocs(mtp) == 0 &&
memstat_get_count(mtp) == 0) memstat_get_count(mtp) == 0)
continue; continue;
xo_open_instance("memory"); xo_open_instance("memory");
xo_emit("{k:type/%13s/%s} {:in-use/%5ju} " xo_emit("{k:type/%13s/%s} {:in-use/%5ju} "
"{:memory-use/%5ju}{U:K} {:high-use/%7s} " "{:memory-use/%5ju}{U:K} {:high-use/%7s} "
"{:requests/%8ju} ", "{:requests/%8ju} ",
memstat_get_name(mtp), (uintmax_t)memstat_get_count(mtp), memstat_get_name(mtp), (uintmax_t)memstat_get_count(mtp),
((uintmax_t)memstat_get_bytes(mtp) + 1023) / 1024, "-", ((uintmax_t)memstat_get_bytes(mtp) + 1023) / 1024, "-",
(uintmax_t)memstat_get_numallocs(mtp)); (uintmax_t)memstat_get_numallocs(mtp));
first = 1; first = 1;
xo_open_list("size"); xo_open_list("size");
for (i = 0; i < 32; i++) { for (i = 0; i < zones; i++) {
if (memstat_get_sizemask(mtp) & (1 << i)) { if (memstat_malloc_zone_used(mtp, i)) {
if (!first) if (!first)
xo_emit(","); xo_emit(",");
xo_emit("{l:size/%d}", 1 << (i + 4)); xo_emit("{l:size/%d}", memstat_malloc_zone_get_size(i));
first = 0; first = 0;
} }
} }
xo_close_list("size"); xo_close_list("size");
xo_close_instance("memory"); xo_close_instance("memory");
xo_emit("\n"); xo_emit("\n");
} }
xo_close_list("memory"); xo_close_list("memory");
▲ Show 20 Lines • Show All 242 Lines • Show Last 20 Lines
View Options

tools/test/avx_sig/avx_sig.c

Show First 20 Lines • Show All 1,401 Lines • ▼ Show 20 Linesdointr(unsigned int interval, int reps)
xo_close_container("interrupt-statistics"); xo_close_container("interrupt-statistics");
} }
static void static void
domemstat_malloc(void) domemstat_malloc(void)
{ {
struct memory_type_list *mtlp; struct memory_type_list *mtlp;
struct memory_type *mtp; struct memory_type *mtp;
int error, first, i; size_t i, zones;
int error, first;
mtlp = memstat_mtl_alloc(); mtlp = memstat_mtl_alloc();
if (mtlp == NULL) { if (mtlp == NULL) {
xo_warn("memstat_mtl_alloc"); xo_warn("memstat_mtl_alloc");
return; return;
} }
if (kd == NULL) { if (kd == NULL) {
if (memstat_sysctl_malloc(mtlp, 0) < 0) { if (memstat_sysctl_malloc(mtlp, 0) < 0) {
xo_warnx("memstat_sysctl_malloc: %s", xo_warnx("memstat_sysctl_malloc: %s",
memstat_strerror(memstat_mtl_geterror(mtlp))); memstat_strerror(memstat_mtl_geterror(mtlp)));
return; return;
} }
markjUnsubmitted
Not Done
Inline Actions

This won't work if running against a vmcore.

markj: This won't work if running against a vmcore.
} else { } else {
if (memstat_kvm_malloc(mtlp, kd) < 0) { if (memstat_kvm_malloc(mtlp, kd) < 0) {
error = memstat_mtl_geterror(mtlp); error = memstat_mtl_geterror(mtlp);
if (error == MEMSTAT_ERROR_KVM) if (error == MEMSTAT_ERROR_KVM)
xo_warnx("memstat_kvm_malloc: %s", xo_warnx("memstat_kvm_malloc: %s",
kvm_geterr(kd)); kvm_geterr(kd));
else else
xo_warnx("memstat_kvm_malloc: %s", xo_warnx("memstat_kvm_malloc: %s",
memstat_strerror(error)); memstat_strerror(error));
} }
} }
xo_open_container("malloc-statistics"); xo_open_container("malloc-statistics");
xo_emit("{T:/%13s} {T:/%5s} {T:/%6s} {T:/%7s} {T:/%8s} {T:Size(s)}\n", xo_emit("{T:/%13s} {T:/%5s} {T:/%6s} {T:/%7s} {T:/%8s} {T:Size(s)}\n",
"Type", "InUse", "MemUse", "HighUse", "Requests"); "Type", "InUse", "MemUse", "HighUse", "Requests");
xo_open_list("memory"); xo_open_list("memory");
zones = memstat_malloc_zone_get_count();
for (mtp = memstat_mtl_first(mtlp); mtp != NULL; for (mtp = memstat_mtl_first(mtlp); mtp != NULL;
mtp = memstat_mtl_next(mtp)) { mtp = memstat_mtl_next(mtp)) {
if (memstat_get_numallocs(mtp) == 0 && if (memstat_get_numallocs(mtp) == 0 &&
memstat_get_count(mtp) == 0) memstat_get_count(mtp) == 0)
continue; continue;
xo_open_instance("memory"); xo_open_instance("memory");
xo_emit("{k:type/%13s/%s} {:in-use/%5ju} " xo_emit("{k:type/%13s/%s} {:in-use/%5ju} "
"{:memory-use/%5ju}{U:K} {:high-use/%7s} " "{:memory-use/%5ju}{U:K} {:high-use/%7s} "
"{:requests/%8ju} ", "{:requests/%8ju} ",
memstat_get_name(mtp), (uintmax_t)memstat_get_count(mtp), memstat_get_name(mtp), (uintmax_t)memstat_get_count(mtp),
((uintmax_t)memstat_get_bytes(mtp) + 1023) / 1024, "-", ((uintmax_t)memstat_get_bytes(mtp) + 1023) / 1024, "-",
(uintmax_t)memstat_get_numallocs(mtp)); (uintmax_t)memstat_get_numallocs(mtp));
first = 1; first = 1;
xo_open_list("size"); xo_open_list("size");
for (i = 0; i < 32; i++) { for (i = 0; i < zones; i++) {
if (memstat_get_sizemask(mtp) & (1 << i)) { if (memstat_malloc_zone_used(mtp, i)) {
if (!first) if (!first)
xo_emit(","); xo_emit(",");
xo_emit("{l:size/%d}", 1 << (i + 4)); xo_emit("{l:size/%d}", memstat_malloc_zone_get_size(i));
first = 0; first = 0;
} }
} }
xo_close_list("size"); xo_close_list("size");
xo_close_instance("memory"); xo_close_instance("memory");
xo_emit("\n"); xo_emit("\n");
} }
xo_close_list("memory"); xo_close_list("memory");
▲ Show 20 Lines • Show All 242 Lines • Show Last 20 Lines
View Options

tools/test/avx_sig/c2x2c_aarch64.S

Show First 20 Lines • Show All 1,401 Lines • ▼ Show 20 Linesdointr(unsigned int interval, int reps)
xo_close_container("interrupt-statistics"); xo_close_container("interrupt-statistics");
} }
static void static void
domemstat_malloc(void) domemstat_malloc(void)
{ {
struct memory_type_list *mtlp; struct memory_type_list *mtlp;
struct memory_type *mtp; struct memory_type *mtp;
int error, first, i; size_t i, zones;
int error, first;
mtlp = memstat_mtl_alloc(); mtlp = memstat_mtl_alloc();
if (mtlp == NULL) { if (mtlp == NULL) {
xo_warn("memstat_mtl_alloc"); xo_warn("memstat_mtl_alloc");
return; return;
} }
if (kd == NULL) { if (kd == NULL) {
if (memstat_sysctl_malloc(mtlp, 0) < 0) { if (memstat_sysctl_malloc(mtlp, 0) < 0) {
xo_warnx("memstat_sysctl_malloc: %s", xo_warnx("memstat_sysctl_malloc: %s",
memstat_strerror(memstat_mtl_geterror(mtlp))); memstat_strerror(memstat_mtl_geterror(mtlp)));
return; return;
} }
markjUnsubmitted
Not Done
Inline Actions

This won't work if running against a vmcore.

markj: This won't work if running against a vmcore.
} else { } else {
if (memstat_kvm_malloc(mtlp, kd) < 0) { if (memstat_kvm_malloc(mtlp, kd) < 0) {
error = memstat_mtl_geterror(mtlp); error = memstat_mtl_geterror(mtlp);
if (error == MEMSTAT_ERROR_KVM) if (error == MEMSTAT_ERROR_KVM)
xo_warnx("memstat_kvm_malloc: %s", xo_warnx("memstat_kvm_malloc: %s",
kvm_geterr(kd)); kvm_geterr(kd));
else else
xo_warnx("memstat_kvm_malloc: %s", xo_warnx("memstat_kvm_malloc: %s",
memstat_strerror(error)); memstat_strerror(error));
} }
} }
xo_open_container("malloc-statistics"); xo_open_container("malloc-statistics");
xo_emit("{T:/%13s} {T:/%5s} {T:/%6s} {T:/%7s} {T:/%8s} {T:Size(s)}\n", xo_emit("{T:/%13s} {T:/%5s} {T:/%6s} {T:/%7s} {T:/%8s} {T:Size(s)}\n",
"Type", "InUse", "MemUse", "HighUse", "Requests"); "Type", "InUse", "MemUse", "HighUse", "Requests");
xo_open_list("memory"); xo_open_list("memory");
zones = memstat_malloc_zone_get_count();
for (mtp = memstat_mtl_first(mtlp); mtp != NULL; for (mtp = memstat_mtl_first(mtlp); mtp != NULL;
mtp = memstat_mtl_next(mtp)) { mtp = memstat_mtl_next(mtp)) {
if (memstat_get_numallocs(mtp) == 0 && if (memstat_get_numallocs(mtp) == 0 &&
memstat_get_count(mtp) == 0) memstat_get_count(mtp) == 0)
continue; continue;
xo_open_instance("memory"); xo_open_instance("memory");
xo_emit("{k:type/%13s/%s} {:in-use/%5ju} " xo_emit("{k:type/%13s/%s} {:in-use/%5ju} "
"{:memory-use/%5ju}{U:K} {:high-use/%7s} " "{:memory-use/%5ju}{U:K} {:high-use/%7s} "
"{:requests/%8ju} ", "{:requests/%8ju} ",
memstat_get_name(mtp), (uintmax_t)memstat_get_count(mtp), memstat_get_name(mtp), (uintmax_t)memstat_get_count(mtp),
((uintmax_t)memstat_get_bytes(mtp) + 1023) / 1024, "-", ((uintmax_t)memstat_get_bytes(mtp) + 1023) / 1024, "-",
(uintmax_t)memstat_get_numallocs(mtp)); (uintmax_t)memstat_get_numallocs(mtp));
first = 1; first = 1;
xo_open_list("size"); xo_open_list("size");
for (i = 0; i < 32; i++) { for (i = 0; i < zones; i++) {
if (memstat_get_sizemask(mtp) & (1 << i)) { if (memstat_malloc_zone_used(mtp, i)) {
if (!first) if (!first)
xo_emit(","); xo_emit(",");
xo_emit("{l:size/%d}", 1 << (i + 4)); xo_emit("{l:size/%d}", memstat_malloc_zone_get_size(i));
first = 0; first = 0;
} }
} }
xo_close_list("size"); xo_close_list("size");
xo_close_instance("memory"); xo_close_instance("memory");
xo_emit("\n"); xo_emit("\n");
} }
xo_close_list("memory"); xo_close_list("memory");
▲ Show 20 Lines • Show All 242 Lines • Show Last 20 Lines