Differential D37573

devctl: allow to register a hook to receive the events
ClosedPublic
Actions

Authored by bapt on Nov 30 2022, 5:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 2:17 AM

	Unknown Object (File)
	Thu, Apr 25, 1:33 AM

	Unknown Object (File)
	Mon, Apr 22, 6:21 AM

	Unknown Object (File)
	Sat, Apr 20, 3:49 AM

	Unknown Object (File)
	Fri, Mar 29, 4:01 PM

	Unknown Object (File)
	Mar 18 2024, 11:42 PM

	Unknown Object (File)
	Mar 18 2024, 11:42 PM

	Unknown Object (File)
	Mar 18 2024, 11:41 PM

View All 54 Files

Subscribers

ihor_antonovs.family

Details

Reviewers

Commits

rGafbb26b58b93: devctl: allow to register a hook to receive the events

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 51608
Build 48499: arc lint + arc unit

Event Timeline

bapt created this revision.Nov 30 2022, 5:06 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 30 2022, 5:06 PM

bapt requested review of this revision.Nov 30 2022, 5:06 PM

Harbormaster completed remote builds in B48574: Diff 113684.Nov 30 2022, 5:06 PM

bapt mentioned this in D37574: nlsysevent: add a genetlink(4) module to report kernel events.Nov 30 2022, 5:08 PM

imp added inline comments.Nov 30 2022, 5:09 PM

sys/kern/kern_devctl.c
139	why only one?
443	and why here rather than in devctl_queue?

bapt added inline comments.Dec 1 2022, 8:18 AM

sys/kern/kern_devctl.c
139	because I didn't plan to add more hooks, but I can turn it into a hook.
443	Look at D37574 my goal is to be able to allow consumers to subscribe at the "system" level" so I don't want the message to be preformated.

Remove extra tab

Harbormaster completed remote builds in B48584: Diff 113738.Dec 1 2022, 8:20 AM

imp added inline comments.Dec 1 2022, 2:37 PM

sys/kern/kern_devctl.c
443	You're missing all the device events if you do this then. It's too high a level. And the messages already are pre-formatted by the time they get here, except for the system, subsystem and type that are added. The data that's passed in is already a bunch of keyword=value pairs that are created using certain rules to avoid quoting issues.

Add all the device events
Add a generic structure for events classification

Harbormaster completed remote builds in B51608: Diff 122232.May 22 2023, 7:50 PM

bapt marked an inline comment as done.May 22 2023, 7:58 PM

Kill the enum

Harbormaster completed remote builds in B51829: Diff 122704.Jun 1 2023, 2:02 PM

emaste added a subscriber: emaste.Jun 1 2023, 2:31 PM

ihor_antonovs.family added a subscriber: ihor_antonovs.family.Jun 1 2023, 2:41 PM

bapt added a reviewer: imp.Jun 1 2023, 3:09 PM

imp accepted this revision.Jun 1 2023, 6:06 PM

imp added inline comments.

sys/sys/devctl.h
37	This might be better committed with a different commit since it's unreferenced here.

This revision is now accepted and ready to land.Jun 1 2023, 6:06 PM

Closed by commit rGafbb26b58b93: devctl: allow to register a hook to receive the events (authored by bapt). · Explain WhyJun 1 2023, 9:02 PM

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rGafbb26b58b93: devctl: allow to register a hook to receive the events.

Revision Contents
Changeset List

Path

Size

sys/

kern/

35 lines

sys/

54 lines

Diff 122232

sys/kern/kern_devctl.c

Loading...

sys/sys/devctl.h

Loading...