Differential D40100

linux(4): Check fd passed to unlockpt()
ClosedPublic
Actions

Authored by dchagin on May 14 2023, 11:18 PM.

Tags

Referenced Files

	F131443230: D40100.diff
	Wed, Oct 8, 3:06 AM

	Unknown Object (File)
	Thu, Oct 2, 3:51 PM

	Unknown Object (File)
	Sep 3 2025, 10:47 PM

	Unknown Object (File)
	Aug 31 2025, 1:59 AM

	Unknown Object (File)
	Aug 23 2025, 5:20 AM

	Unknown Object (File)
	Aug 19 2025, 9:59 AM

	Unknown Object (File)
	Aug 14 2025, 12:03 PM

	Unknown Object (File)
	Jul 29 2025, 1:51 AM

View All 89 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Linux Emulation

Commits

rGaddf706f6ff0: linux(4): Check fd passed to unlockpt()
rG0f62290e7f74: linux(4): Check fd passed to unlockpt()

Summary

In our implementation, grantpt() and unlockpt() don't actually have
any use, because PTY's are created on the fly and already have proper
permissions upon creation.
Atleast check that a proper fd passed to unlockpt(). For grantpt()
Glibc calls TIOCGPTN ioctl which would fail if fd is not a master.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin created this revision.May 14 2023, 11:18 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 14 2023, 11:18 PM

dchagin requested review of this revision.May 14 2023, 11:18 PM

Harbormaster completed remote builds in B51496: Diff 121950.May 14 2023, 11:18 PM

dchagin added a reviewer: Linux Emulation.May 14 2023, 11:21 PM

dchagin added a project: Linux Emulation.

This revision was not accepted when it landed; it landed in state Needs Review.May 18 2023, 7:56 AM

Closed by commit rG0f62290e7f74: linux(4): Check fd passed to unlockpt() (authored by dchagin). · Explain Why

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rG0f62290e7f74: linux(4): Check fd passed to unlockpt().

dchagin added a commit: rGaddf706f6ff0: linux(4): Check fd passed to unlockpt().Jun 29 2023, 8:26 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

8 lines

Diff 122064

sys/compat/linux/linux_ioctl.c

Loading...