Page MenuHomeFreeBSD

git-ghpr: A script to land github pull requests
Needs ReviewPublic

Authored by imp on May 9 2023, 4:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 23 2026, 1:56 AM
Unknown Object (File)
May 7 2026, 1:31 AM
Unknown Object (File)
May 6 2026, 6:17 AM
Unknown Object (File)
May 4 2026, 2:50 PM
Unknown Object (File)
May 3 2026, 7:28 AM
Unknown Object (File)
Apr 30 2026, 7:02 AM
Unknown Object (File)
Apr 27 2026, 10:37 AM
Unknown Object (File)
Apr 27 2026, 8:22 AM

Details

Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51399
Build 48290: arc lint + arc unit

Event Timeline

imp requested review of this revision.May 9 2023, 4:45 PM
imp created this revision.
tools/tools/git/git-ghpr
206

I guess "Reviewed by: imp" shouldn't be hard-coded? :)

tools/tools/git/git-ghpr
206

also perhaps some commentary on $HOME/bin/git-fixup-editor

tools/tools/git/git-ghpr
206

ah, yea, likely shouldn't be hard coded.
And git-fixup=editor likely should be included here as well.

#!/bin/sh

# Takes 1 arg, the file to edit

fn=$1
dir=$(mktemp -d gfe-XXXXXXXXXXXX)
ofn=$dir/msg

trap "rm -rf $dir" EXIT

sed -e 's/^Reviewed-by:/Reviewed by:/;
        s/^Pull-Request:/Pull Request:/;
        s/^Differential-Revision:/Differential Revision:/' < $fn > $ofn && mv $ofn $fn

is what it does.

This gets back to a point I'd like to raise: We should ditch the 'metadata with spaces' thing and move to more-standard metadata so that the git commit --trailer stuff can be used in the tooling.

This gets back to a point I'd like to raise: We should ditch the 'metadata with spaces' thing and move to more-standard metadata

Yes, I'm fine with us updating the commit template, handbook etc. (and adding a note that metadata used to use spaces). I created D40025 for the commit template.