Page MenuHomeFreeBSD
Differential D39820

arm64/disassem.c: make output in lowercase register to consistency
ClosedPublic
Actions

Authored by koliagogsadze_gmail.com on Apr 25 2023, 10:06 PM.
Tags
None
Referenced Files
F167218380: D39820.id122419.diff
Thu, Aug 20, 1:03 AM
Unknown Object (File)
Tue, Aug 11, 2:10 PM
Unknown Object (File)
Sun, Aug 9, 10:58 AM
Unknown Object (File)
Fri, Aug 7, 3:02 PM
Unknown Object (File)
Fri, Aug 7, 12:22 PM
Unknown Object (File)
Thu, Aug 6, 10:37 AM
Unknown Object (File)
Wed, Aug 5, 9:26 AM
Unknown Object (File)
Sun, Jul 26, 5:04 PM
View All Files
Subscribers
emaste
imp

Details

Reviewers
mhorne
andrew
manu
Commits
rG8a852d3e9ff7: arm64/disassem.c: Make output lowercase
Summary

Updated output to lowercase to consistency

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51372
Build 48263: arc lint + arc unit

Event Timeline

koliagogsadze_gmail.com created this revision.Apr 25 2023, 10:06 PM
Herald added a reviewer: manu. · View Herald TranscriptApr 25 2023, 10:06 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
koliagogsadze_gmail.com requested review of this revision.Apr 25 2023, 10:06 PM
Harbormaster completed remote builds in B51198: Diff 121049.Apr 25 2023, 10:06 PM
koliagogsadze_gmail.com updated this revision to Diff 121051.Apr 25 2023, 10:27 PM
mhorne accepted this revision.Apr 26 2023, 2:19 PM

This seems good. It appears to match the disassembly output from llvm-objdump.

In the future, please include full context when uploading the diff. This can be done with, for example, git show -U99999.

This revision is now accepted and ready to land.Apr 26 2023, 2:19 PM
koliagogsadze_gmail.com updated this revision to Diff 121689.May 8 2023, 5:24 PM

Rebased with main branch

This revision now requires review to proceed.May 8 2023, 5:24 PM
Harbormaster completed remote builds in B51372: Diff 121689.May 8 2023, 5:24 PM
mhorne accepted this revision.May 12 2023, 11:39 AM
This revision is now accepted and ready to land.May 12 2023, 11:39 AM
mhorne mentioned this in D40006: arm64/disassem.c: Add support insts of shifted register with rsv option.May 22 2023, 1:14 PM
Closed by commit rG8a852d3e9ff7: arm64/disassem.c: Make output lowercase (authored by koliagogsadze_gmail.com, committed by mhorne). · Explain WhyMay 25 2023, 5:06 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG8a852d3e9ff7: arm64/disassem.c: Make output lowercase.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
8 lines

Diff 121689

View Options

sys/arm64/arm64/disassem.c

Loading...