Page MenuHomeFreeBSD
Differential D39939

lldb: dereference stoppcbs based on target kernel version
ClosedPublic
Actions

Authored by emaste on May 2 2023, 8:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 1:35 AM
Unknown Object (File)
Sat, Apr 27, 1:35 AM
Unknown Object (File)
Sat, Apr 27, 1:35 AM
Unknown Object (File)
Sat, Apr 27, 12:33 AM
Unknown Object (File)
Fri, Apr 26, 10:34 PM
Unknown Object (File)
Sun, Apr 14, 8:13 PM
Unknown Object (File)
Sun, Apr 14, 5:46 PM
Unknown Object (File)
Sun, Apr 14, 5:45 PM
View All 42 Files
Subscribers
imp
jhb

Details

Reviewers
markj
dim
Commits
rG104cc21de8d6: lldb: dereference stoppcbs based on target kernel version
rG0f2bb40bc7dd: lldb: dereference stoppcbs based on target kernel version
Summary
As of [some hash] / __FreeBSD_version [some version]  stoppcbs is a
pointer to the array.  Check the target osreldate and if the kernel is
sufficiently new dereference stoppcbs.

Xref D39806. This change is not yet tested, posting for discussion.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.May 2 2023, 8:28 PM
emaste created this revision.
emaste mentioned this in D39806: smp: Dynamically allocate the stoppcbs array.
emaste added inline comments.May 2 2023, 8:32 PM
contrib/llvm-project/lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.cpp
185

Perhaps (stoppcbs != LLDB_INVALID_ADDRESS && osreldate > 1400088)

emaste added reviewers: markj, dim.May 2 2023, 8:32 PM
emaste added a subscriber: jhb.May 2 2023, 11:26 PM
markj accepted this revision.May 3 2023, 1:50 PM
This revision is now accepted and ready to land.May 3 2023, 1:50 PM
emaste updated this revision to Diff 121484.May 3 2023, 4:48 PM

Drop XXX comment, add stoppcbs != LLDB_INVALID_ADDRESS to condition.

This revision now requires review to proceed.May 3 2023, 4:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 26 2023, 1:50 AM
Closed by commit rG0f2bb40bc7dd: lldb: dereference stoppcbs based on target kernel version (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG0f2bb40bc7dd: lldb: dereference stoppcbs based on target kernel version.
Herald added a subscriber: imp. · View Herald TranscriptMay 26 2023, 1:50 AM
dim added a commit: rG104cc21de8d6: lldb: dereference stoppcbs based on target kernel version.Jan 7 2024, 11:10 PM

Revision Contents
Changeset List

PathSize
contrib/
llvm-project/
lldb/
source/
Plugins/
Process/
FreeBSDKernel/
5 lines

Diff 121484

View Options

contrib/llvm-project/lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.cpp

Loading...