Page MenuHomeFreeBSD
Differential D39759

al_eth: make function definitions consistent with declarations
ClosedPublic
Actions

Authored by dim on Apr 22 2023, 12:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 21, 10:20 PM
Unknown Object (File)
Sun, Sep 13, 3:21 AM
Unknown Object (File)
Fri, Sep 11, 7:44 PM
Unknown Object (File)
Fri, Sep 11, 5:02 AM
Unknown Object (File)
Fri, Sep 11, 4:59 AM
Unknown Object (File)
Aug 16 2026, 1:45 AM
Unknown Object (File)
Aug 13 2026, 8:52 PM
Unknown Object (File)
Aug 10 2026, 7:55 AM
View All 87 Files
Subscribers
imp
mw

Details

Reviewers
jhibbits
jhb
emaste
Commits
rGaee90183065e: al_eth: make function definitions consistent with declarations
rG99a98c68f441: al_eth: make function definitions consistent with declarations
rG9ea31d78f00d: al_eth: make function definitions consistent with declarations
Summary

The declarations for al_eth_lm_retimer_ds25_signal_detect() and
al_eth_lm_retimer_ds25_cdr_lock() say that these functions return
'al_bool', but the definitions actually return 'boolean_t'.

Make the definitions match the declarations.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51119
Build 48010: arc lint + arc unit

Event Timeline

dim created this revision.Apr 22 2023, 12:03 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 22 2023, 12:03 PM
dim requested review of this revision.Apr 22 2023, 12:03 PM
Harbormaster completed remote builds in B51119: Diff 120854.Apr 22 2023, 12:03 PM
dim added reviewers: jhibbits, jhb, emaste.Apr 22 2023, 12:05 PM
emaste accepted this revision.Apr 24 2023, 1:50 PM
emaste added a subscriber: mw.

OK, although we may want to either just use int to match struct al_eth_lm_retimer, or change struct al_eth_lm_retimer to al_bool as well.

This revision is now accepted and ready to land.Apr 24 2023, 1:50 PM
jhb accepted this revision.Apr 25 2023, 4:48 PM

Or just replace al_bool with C99 bool, but that can be done in a future change.

Closed by commit rG9ea31d78f00d: al_eth: make function definitions consistent with declarations (authored by dim). · Explain WhyApr 25 2023, 6:03 PM
This revision was automatically updated to reflect the committed changes.
dim added a commit: rG9ea31d78f00d: al_eth: make function definitions consistent with declarations.
dim added a commit: rG99a98c68f441: al_eth: make function definitions consistent with declarations.Apr 29 2023, 7:38 AM
dim added a commit: rGaee90183065e: al_eth: make function definitions consistent with declarations.

Revision Contents
Changeset List

PathSize
sys/
dev/
al_eth/
4 lines

Diff 120854

View Options

sys/dev/al_eth/al_init_eth_lm.c

Loading...