libpmcstat: Extract parts of pmcstat_image_get_elf_params
AcceptedPublic
Actions

Authored by jrtc27 on Apr 17 2023, 7:50 PM.

Details

Reviewers

jhb
jkoshy
mhorne
mjg

Summary

These parts of the function will also be needed when parsing separate
debug files, so extract them to new internal functions that can be
reused when doing so in a future commit.

As part of this, fix up all the warning messages to use the right path
when fd refers to FSROOT/boot/modules/NAME; previously it always used
the FSROOT/KERNELPATH/NAME string which could get confusing. Also fix a
style issue for the done label.

MFC after: 1 month

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 50970
Build 47861: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Apr 17 2023, 7:50 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 17 2023, 7:50 PM

jrtc27 requested review of this revision.Apr 17 2023, 7:50 PM

Harbormaster completed remote builds in B50970: Diff 120501.Apr 17 2023, 7:50 PM

jrtc27 added a child revision: D39626: libpmcstat: Teach pmcstat_image_get_elf_params about debug files.Apr 17 2023, 7:57 PM

Initialise minva/maxva in the right place

Harbormaster completed remote builds in B50976: Diff 120511.Apr 17 2023, 8:34 PM

emaste added a subscriber: emaste.Apr 18 2023, 2:25 PM

jhb accepted this revision.Apr 18 2023, 5:40 PM

jhb added inline comments.

lib/libpmcstat/libpmcstat_image.c
425	Why are we not exporting the full path for kernel modules? The kernel linker stores the full path of the module (and has for many years now). We should probably fix that (and since you are bumping the major version of PMC maybe go ahead and fix that as part of this series?)

This revision is now accepted and ready to land.Apr 18 2023, 5:40 PM

jrtc27 added inline comments.Apr 18 2023, 5:58 PM

lib/libpmcstat/libpmcstat_image.c
425	Can that be relied upon, or is pathname sometimes still not full? Otherwise looks straightforward, just two places to switch I believe.

jhb added inline comments.Apr 18 2023, 6:09 PM

lib/libpmcstat/libpmcstat_image.c
425	kgdb has relied upon it for over a decade I think (maybe 15 years?) 16 years actually: https://github.com/freebsd/freebsd-src/commit/1676805c186f5dea36d331a982480d7d9693b126 hwpmc just predates this change I think and was never updated to catch up

Revision Contents
Changeset List

Path

Size

lib/

libpmcstat/

libpmcstat_image.c

171 lines

Diff 120501

View Options

lib/libpmcstat/libpmcstat_image.c

libpmcstat: Extract parts of pmcstat_image_get_elf_paramsAcceptedPublicActions