Paths

Table of Contentst

Differential D39481

dtrace: handle NOP instructions in RISC-V
ClosedPublic
Actions

Authored by christos on Apr 10 2023, 12:38 PM.

Tags

Referenced Files

	Unknown Object (File)
	Tue, Nov 18, 2:17 PM

	Unknown Object (File)
	Sat, Nov 15, 7:37 AM

	Unknown Object (File)
	Nov 5 2025, 4:15 AM

	Unknown Object (File)
	Oct 26 2025, 10:56 PM

	Unknown Object (File)
	Oct 23 2025, 9:00 PM

	Unknown Object (File)
	Oct 20 2025, 7:45 PM

	Unknown Object (File)
	Oct 17 2025, 3:43 AM

	Unknown Object (File)
	Oct 14 2025, 7:03 PM

View All 97 Files

Subscribers

Details

Reviewers

markj
mhorne
gnn

Commits

rG0388a0887a8d: dtrace: handle NOP instructions in the riscv invop handler

Summary

dtrace_invop_start() was panicking if the provider returned
MATCH_C_NOP (DTRACE_INVOP_NOP).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

christos created this revision.Apr 10 2023, 12:38 PM

Herald added a reviewer: gnn. · View Herald TranscriptApr 10 2023, 12:38 PM

Herald added a subscriber: imp. · View Herald Transcript

christos requested review of this revision.Apr 10 2023, 12:38 PM

markj added inline comments.Apr 10 2023, 1:56 PM

sys/cddl/dev/dtrace/riscv/dtrace_subr.c
275	It looks like fbt_invop() returns the original instruction, rather than using the DTRACE_INVOP_* constants. In particular, fbt->fbt_rval is not used anywhere. We should thus return a nop instruction and match it the way other instructions are matched, rather than having multiple return types.

christos updated this revision to Diff 120078.Apr 10 2023, 3:00 PM

christos marked an inline comment as done.

christos retitled this revision from dtrace: handle DTRACE_INVOP_NOP in RISC-V to dtrace: handle NOP instructions in RISC-V.

christos edited the summary of this revision. (Show Details)

markj accepted this revision.Apr 10 2023, 3:03 PM

This revision is now accepted and ready to land.Apr 10 2023, 3:03 PM

Closed by commit rG0388a0887a8d: dtrace: handle NOP instructions in the riscv invop handler (authored by christos, committed by markj). · Explain WhyApr 10 2023, 4:15 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG0388a0887a8d: dtrace: handle NOP instructions in the riscv invop handler.

Revision Contents
Changeset List

Path

Size

sys/

cddl/

dev/

dtrace/

riscv/

3 lines

Diff 120078

sys/cddl/dev/dtrace/riscv/dtrace_subr.c

Loading...