Details

Reviewers

matthew

Group Reviewers

Python

Commits

R11:5d4139f8bdb6: devel/py-setuptools-scm: update to 8.0.4

Summary

Switch to USE_PYTHON= pep517 pytest

Add devel/py-wheel as a BUILD_DEPENDS -- not mentioned in upstream
pyproject.toml, but clearly needed for building.

Add security/gnupg, devel/git and devel/mercurial to TEST_DEPENDS
since so many tests require them. Do not add (eg.) sysutils/coreutils
for dir or ressurect the expired devel/py-hg-git for particular
tests.

Delete all patch files as these are no longer necessary

ChangeLog: https://github.com/pypa/setuptools_scm/blob/v7.1.0/CHANGELOG.rst

Test Plan

make test

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50637
Build 47528: arc lint + arc unit

Event Timeline

matthew created this revision.Mar 27 2023, 12:16 PM

Herald added a subscriber: mat. · View Herald TranscriptMar 27 2023, 12:16 PM

matthew requested review of this revision.Mar 27 2023, 12:16 PM

Harbormaster completed remote builds in B50603: Diff 119509.Mar 27 2023, 12:16 PM

Can we update devel/py-setuptools_scm please? This builds correctly in poudriere, and make test passes.

This needs to wait until after D39095 and D39303 land. setuptools does not have wheel functionality of its own, so it will depend on wheel after the former lands.

devel/py-setuptools_scm/Makefile
15–18
19–20	Even though technically needed, cannot have this here due to downstream environment pollution. Consumers will explicitly specify setuptools in addition to this.

devel/py-setuptools_scm: avoid environment pollution

Ports will specify their own requirements on setuptools versions,
which (although technically a requirement from upstream for _this_
package) we shouln't override here.

Harbormaster completed remote builds in B50637: Diff 119591.Mar 29 2023, 7:55 AM

matthew marked 2 inline comments as done.Mar 29 2023, 7:55 AM

devel/py-setuptools_scm: Ensure tests use python modules from ${STAGEDIR}

This allows make test to work when building a newer version of the
package on a system where an older version is already installed.

Harbormaster completed remote builds in B50639: Diff 119597.Mar 29 2023, 9:21 AM

updating this to 8.0.4

vishwin retitled this revision from devel/py-setuptools_scm: update to 7.1.0 to devel/py-setuptools_scm: update to 8.0.4.Oct 12 2023, 4:44 AM

update to 8.0.4

round one of probably many, directory name to change

Harbormaster completed remote builds in B53934: Diff 128645.Oct 12 2023, 5:15 AM

devel/py-setuptools_scm: move directory to match updated package name
devel/py-setuptools-scm: switch consumers

Herald added a subscriber: dab. · View Herald TranscriptOct 12 2023, 5:45 AM

Harbormaster completed remote builds in B53935: Diff 128646.Oct 12 2023, 5:45 AM

Updating the port, renaming the port and updating all of the dependencies makes this very hard to review. Would have been easier separated into two bits. Just the port update in one, and all the bits connected to renaming the port in the other.

Anyhow:

Port update bits in https://reviews.freebsd.org/differential/diff/128646/ -- looks good to me.

Renaming related stuff: I can't see any obvious errors, seems fine.

Since all of the consumers of devel/py-setuptools_scm7 have been switched to the updated devel/py-setuptools-scm there's no point keeping devel/py-setuptools_scm7. Happy for that to be deleted.

devel/py-setuptools-scm: add BUILD_DEPENDS=${PY_SETUPTOOLS} to consumers
devel/py-{flit-scm,hatch-vcs}: add RUN_DEPENDS=${PY_SETUPTOOLS}

Yeah it's unfortunate that this review ballooned significantly, but the package name change, however subtle, forced the hand. Hacking ${DISTNAME} or only adjusting ${PORTNAME} weren't going to do. As a side effect, this takes some load off D39303.

An exp-run will be requested.

Harbormaster completed remote builds in B53937: Diff 128649.Oct 12 2023, 7:56 AM