Differential D39197

libpmc: Use LIB_CXX instead of explicit LDADD to link a C++ library.
ClosedPublic
Actions

Authored by jhb on Mar 22 2023, 2:46 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	May 13 2026, 5:13 PM

	Unknown Object (File)
	May 13 2026, 9:40 AM

	Unknown Object (File)
	May 13 2026, 9:40 AM

	Unknown Object (File)
	May 12 2026, 7:49 AM

	Unknown Object (File)
	May 12 2026, 1:23 AM

	Unknown Object (File)
	Apr 27 2026, 1:40 PM

	Unknown Object (File)
	Apr 19 2026, 3:48 AM

	Unknown Object (File)
	Apr 18 2026, 7:52 PM

View All 100 Files

Subscribers

Details

Reviewers

emaste
asomers

Commits

rGf5db29b8ceb5: libpmc: Use LIB_CXX instead of explicit LDADD to link a C++ library.
rG076116b88474: libpmc: Use LIB_CXX instead of explicit LDADD to link a C++ library.
rGc6b3f47fedd3: libpmc: Use LIB_CXX instead of explicit LDADD to link a C++ library.

Summary

This uses the C++ compiler as the linker instead of the C compiler
letting the compiler driver pick the right libraries. This is a no-op
on main and stable/13 but matters for stable/12 where the current
logic breaks for external GCC since it tries to use a non-existent
libstdc++.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50509
Build 47400: arc lint + arc unit

Event Timeline

jhb created this revision.Mar 22 2023, 2:46 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 22 2023, 2:47 AM

jhb requested review of this revision.Mar 22 2023, 2:47 AM

Harbormaster completed remote builds in B50509: Diff 119227.Mar 22 2023, 2:47 AM

emaste accepted this revision.Mar 23 2023, 1:03 PM

This revision is now accepted and ready to land.Mar 23 2023, 1:03 PM

Closed by commit rGc6b3f47fedd3: libpmc: Use LIB_CXX instead of explicit LDADD to link a C++ library. (authored by jhb). · Explain WhyMar 23 2023, 4:32 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGc6b3f47fedd3: libpmc: Use LIB_CXX instead of explicit LDADD to link a C++ library..

jhb added a commit: rG076116b88474: libpmc: Use LIB_CXX instead of explicit LDADD to link a C++ library..May 2 2023, 5:15 PM

jhb added a commit: rGf5db29b8ceb5: libpmc: Use LIB_CXX instead of explicit LDADD to link a C++ library..

Revision Contents
Changeset List

Path

Size

lib/

libpmc/

3 lines

Diff 119227

lib/libpmc/Makefile

Loading...