Page MenuHomeFreeBSD
Differential D39019

tarfs: Correctly track link count.
ClosedPublic
Actions

Authored by des on Mar 10 2023, 5:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 20, 8:47 AM
Unknown Object (File)
Wed, May 20, 7:26 AM
Unknown Object (File)
Tue, May 19, 11:11 AM
Unknown Object (File)
Tue, May 19, 5:31 AM
Unknown Object (File)
Mon, May 18, 11:53 PM
Unknown Object (File)
Sun, May 17, 1:21 AM
Unknown Object (File)
Sat, May 16, 11:47 PM
Unknown Object (File)
Sat, May 16, 11:46 PM
View All Files
Subscribers
imp

Details

Reviewers
sjg
stevek
kib
Group Reviewers
Klara
Commits
rGfd8c98a52f71: tarfs: Correctly track link count.
Summary

Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Mar 10 2023, 5:50 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 10 2023, 5:50 PM
des requested review of this revision.Mar 10 2023, 5:50 PM
Harbormaster completed remote builds in B50281: Diff 118640.Mar 10 2023, 5:50 PM
des added a child revision: D39020: tarfs: Support tar files which include file modes with permissions..Mar 10 2023, 5:50 PM
des abandoned this revision.Mar 10 2023, 5:52 PM

buggy, will resubmit

des reclaimed this revision.Mar 10 2023, 6:27 PM
des updated this revision to Diff 118643.Mar 10 2023, 6:27 PM

Now it works

Harbormaster completed remote builds in B50283: Diff 118643.Mar 10 2023, 6:28 PM
des added a reviewer: kib.Mar 11 2023, 6:22 PM
kib added inline comments.Mar 11 2023, 10:03 PM
sys/fs/tarfs/tarfs_vfsops.c
745

What protects other->nlink during the increment? Could two calls to tarfs_alloc_one() executed in parallel, targeting the same dst node?

Or even, what protects other itself? For instance, could unmount occur in parallel with the tarfs_alloc_one()?

des added inline comments.Mar 13 2023, 2:19 PM
sys/fs/tarfs/tarfs_vfsops.c
745

tarfs_alloc_one() is called sequentially during mount, and tarfs_free_node() is called sequentially during unmount or while cleaning up after a failed mount.

kib accepted this revision.Mar 13 2023, 5:56 PM
This revision is now accepted and ready to land.Mar 13 2023, 5:56 PM
Closed by commit rGfd8c98a52f71: tarfs: Correctly track link count. (authored by des). · Explain WhyMar 16 2023, 12:20 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGfd8c98a52f71: tarfs: Correctly track link count..

Revision Contents
Changeset List

PathSize
sys/
fs/
tarfs/
13 lines
7 lines
tests/
sys/
fs/
tarfs/
2 lines

Diff 118908

View Options

sys/fs/tarfs/tarfs_subr.c

Loading...
View Options

sys/fs/tarfs/tarfs_vfsops.c

Loading...
View Options

tests/sys/fs/tarfs/tarfs_test.sh

Loading...