Page MenuHomeFreeBSD

tarfs: Correctly track link count.
ClosedPublic

Authored by des on Mar 10 2023, 5:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 25, 5:00 PM
Unknown Object (File)
Sun, Jun 23, 11:13 AM
Unknown Object (File)
Jan 14 2024, 7:23 AM
Unknown Object (File)
Dec 25 2023, 8:52 PM
Unknown Object (File)
Dec 20 2023, 6:50 AM
Unknown Object (File)
Jul 9 2023, 8:04 AM
Unknown Object (File)
Jun 24 2023, 7:45 AM
Unknown Object (File)
Jun 24 2023, 4:44 AM
Subscribers

Details

Summary

Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Mar 10 2023, 5:50 PM

buggy, will resubmit

sys/fs/tarfs/tarfs_vfsops.c
745

What protects other->nlink during the increment? Could two calls to tarfs_alloc_one() executed in parallel, targeting the same dst node?

Or even, what protects other itself? For instance, could unmount occur in parallel with the tarfs_alloc_one()?

sys/fs/tarfs/tarfs_vfsops.c
745

tarfs_alloc_one() is called sequentially during mount, and tarfs_free_node() is called sequentially during unmount or while cleaning up after a failed mount.

This revision is now accepted and ready to land.Mar 13 2023, 5:56 PM
This revision was automatically updated to reflect the committed changes.