Page MenuHomeFreeBSD

tarfs: Correctly track link count.
ClosedPublic

Authored by des on Mar 10 2023, 5:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 20, 1:43 PM
Unknown Object (File)
Thu, Sep 10, 7:29 PM
Unknown Object (File)
Sun, Sep 6, 3:15 PM
Unknown Object (File)
Fri, Sep 4, 7:12 PM
Unknown Object (File)
Fri, Sep 4, 8:08 AM
Unknown Object (File)
Thu, Sep 3, 4:31 AM
Unknown Object (File)
Thu, Sep 3, 2:44 AM
Unknown Object (File)
Thu, Sep 3, 12:04 AM
Subscribers

Details

Summary

Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Mar 10 2023, 5:50 PM

buggy, will resubmit

sys/fs/tarfs/tarfs_vfsops.c
745

What protects other->nlink during the increment? Could two calls to tarfs_alloc_one() executed in parallel, targeting the same dst node?

Or even, what protects other itself? For instance, could unmount occur in parallel with the tarfs_alloc_one()?

sys/fs/tarfs/tarfs_vfsops.c
745

tarfs_alloc_one() is called sequentially during mount, and tarfs_free_node() is called sequentially during unmount or while cleaning up after a failed mount.

This revision is now accepted and ready to land.Mar 13 2023, 5:56 PM
This revision was automatically updated to reflect the committed changes.