Changes by Pau Amma from author's version:
- Reformatted for 1 sentence = 1 line.
- Added some markup for consistency with other reports.
Pull Request: https://github.com/freebsd/freebsd-doc/pull/120
Details
Details
- Reviewers
pjfloyd_wanadoo.fr gjb carlavilla salvadore - Group Reviewers
status - Commits
- R9:dff50bc55d98: Status/2023Q1: Add Valgrind report
Diff Detail
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 50344 Build 47236: arc lint + arc unit
Event Timeline
Comment Actions
There is something wrong in those lines about AsciiDoc syntax. See also the rendered result at https://github.com/paulfloyd/freebsd-doc/blob/paulfloyd-valgrind-2023Q1/website/content/en/status/report-2023-01-2023-03/valgrind.adoc .
| website/content/en/status/report-2023-01-2023-03/valgrind.adoc | ||
|---|---|---|
| 2 | This starts correctly with ===, but should not end with ===. | |
| 4 | This should be Links: + for consistency with other reports. (By the way, I see we have missed the : last quarter too in the valgrind report. I will fix it when I find time.) | |
| 5 | It needs + at the end of line. | |
| 10 | We could use package:devel/valgrind-devel[] here. | |
| website/content/en/status/report-2023-01-2023-03/valgrind.adoc | ||
|---|---|---|
| 4 | Correction: we did not have a valgrind report last quarter. It was 2022Q2. | |
Comment Actions
Should take care of all comments.
| website/content/en/status/report-2023-01-2023-03/valgrind.adoc | ||
|---|---|---|
| 2 | Ooops. (Guess who's been editing Wikipedia lately.) | |
Comment Actions
Looks goot do me, thanks @pauamma.
By the way, as far as status is concerned, I think we do not need to duplicate reviews already started in GitHub. If you would like to have more eyes looking at some particular pull request, feel free to add me as reviewer there directly.
On the other hand, if you need to create Phabricator reviews anyway for other reasons (maybe asking mentor approval?), this is fine too of course.
Comment Actions
Committed with two minimal changes:
- capitalization of Preparing in the title;
- changed package:devel/valgrind-devel into package:devel/valgrind-devel[].
Thanks @pjfloyd_wanadoo.fr for submitting and @pauamma for reviewing .