Differential D38041

stand/ofw: dev can't be NULL here
ClosedPublic
Actions

Authored by imp on Jan 13 2023, 4:33 PM.

Tags

None

Referenced Files

	F160895223: D38041.id115093.diff
	Sun, Jun 28, 7:51 PM

	Unknown Object (File)
	Wed, Jun 24, 9:24 PM

	Unknown Object (File)
	Wed, Jun 24, 12:34 PM

	Unknown Object (File)
	Fri, Jun 19, 10:17 PM

	Unknown Object (File)
	Fri, Jun 19, 2:11 PM

	Unknown Object (File)
	Fri, Jun 19, 3:17 AM

	Unknown Object (File)
	May 18 2026, 12:39 AM

	Unknown Object (File)
	May 18 2026, 12:38 AM

Subscribers

Details

Reviewers

kevans
manu
tsoome

Commits

rG2f7b00be106f: stand/ofw: dev can't be NULL here
rGd38d8a4c4e9a: stand/ofw: dev can't be NULL here

Summary

dev can't be NULL here. ofw_common_parsedev is always called via
devparse (indirectly through dv_parsedev() calls there which call it
with the args unchanged). In the past, ofw_getdev could call us with
NULL pointer for the parse-only case, but that's now all handled inside
of devparse for simplicity.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49092
Build 45981: arc lint + arc unit

Event Timeline

imp created this revision.Jan 13 2023, 4:33 PM

Herald added a reviewer: manu. · View Herald TranscriptJan 13 2023, 4:33 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Jan 13 2023, 4:33 PM

Harbormaster completed remote builds in B49092: Diff 115048.Jan 13 2023, 4:33 PM

imp added a child revision: D38042: stand/uboot: Explain why we test for NULL here.Jan 13 2023, 4:33 PM

imp added a reviewer: tsoome.Jan 13 2023, 6:38 PM

kevans accepted this revision.Jan 13 2023, 7:39 PM

This revision is now accepted and ready to land.Jan 13 2023, 7:39 PM

Closed by commit rGd38d8a4c4e9a: stand/ofw: dev can't be NULL here (authored by imp). · Explain WhyJan 13 2023, 9:27 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGd38d8a4c4e9a: stand/ofw: dev can't be NULL here.

tsoome added inline comments.Jan 13 2023, 9:29 PM

stand/libofw/devicename.c
111	default_parsedev() is actually testing it too.

Good eye.

imp mentioned this in rG4883f347f6ed: stand: dev can't be NULL in default_prasedev.Jan 13 2023, 10:57 PM

imp added a commit: rG2f7b00be106f: stand/ofw: dev can't be NULL here.Jan 24 2023, 10:21 PM

imp mentioned this in rG3ececb0f35b9: stand: dev can't be NULL in default_prasedev.

Revision Contents
Changeset List

Path

Size

stand/

libofw/

3 lines

Diff 115048

stand/libofw/devicename.c

Loading...