Page MenuHomeFreeBSD
Differential D37626

iee80211_hwmp: Don't dereference NULL ni in debug printf.
ClosedPublic
Actions

Authored by jhb on Dec 7 2022, 8:36 PM.
Tags
None
Referenced Files
F155025341: D37626.diff
Thu, Apr 30, 6:35 PM
Unknown Object (File)
Tue, Apr 28, 4:28 PM
Unknown Object (File)
Tue, Apr 28, 4:25 PM
Unknown Object (File)
Tue, Apr 28, 3:41 AM
Unknown Object (File)
Mon, Apr 27, 9:12 PM
Unknown Object (File)
Fri, Apr 24, 10:16 PM
Unknown Object (File)
Fri, Apr 24, 5:01 PM
Unknown Object (File)
Sat, Apr 11, 10:42 AM
View All Files
Subscribers
glebius
melifaro

Details

Reviewers
emaste
imp
bz
Commits
rG64313140e531: iee80211_hwmp: Don't dereference NULL ni in debug printf.
rG95d146592f5e: iee80211_hwmp: Don't dereference NULL ni in debug printf.
Summary

In this call to IEEE80211_NOTE, ni is always NULL due to the assignment
a few lines earlier at the start of the function. If debug traces are
enabled, then this will pass an invalid pointer as the 'mac' pointer to
ieee80211_note_mac. Use IEEE80211_DPRINTF which doesn't take a 'ni'
argument instead.

Reported by: GCC -Wstringop-overread

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48643
Build 45529: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
net80211/
4 lines

Diff 113928

View Options

sys/net80211/ieee80211_hwmp.c

Loading...