pw: Don't return a pointer to an on-stack buffer from grp_set_passwd.
ClosedPublic
Actions

Authored by jhb on Nov 29 2022, 7:50 PM.

Details

Reviewers

emaste
imp

Commits

rG50367e285d40: pw: Don't return a pointer to an on-stack buffer from grp_set_passwd.
rG1055bedbed42: pw: Don't return a pointer to an on-stack buffer from grp_set_passwd.

Summary

Make 'line' static to move it to .bss instead as that pattern is used
elsewhere in pw(8) (e.g. the static buffer in pw_pwcrypt).

Reported by: GCC -Wdangling-pointer

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48535
Build 45421: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Nov 29 2022, 7:50 PM

jhb created this revision.

Harbormaster completed remote builds in B48535: Diff 113621.Nov 29 2022, 7:50 PM

jhb added a parent revision: D37533: libsa: Disable -Wdangling-pointer for zfs.c..Nov 29 2022, 7:50 PM

jhb added a child revision: D37535: acpica: Quiet a -Wdangling-pointer warning in AcpiUtInitStackPtrTrace..

imp accepted this revision.Nov 29 2022, 8:14 PM

This revision is now accepted and ready to land.Nov 29 2022, 8:14 PM

emaste accepted this revision.Nov 29 2022, 9:53 PM

Closed by commit rG1055bedbed42: pw: Don't return a pointer to an on-stack buffer from grp_set_passwd. (authored by jhb). · Explain WhyDec 5 2022, 12:30 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG1055bedbed42: pw: Don't return a pointer to an on-stack buffer from grp_set_passwd..

jhb added a commit: rG50367e285d40: pw: Don't return a pointer to an on-stack buffer from grp_set_passwd..May 3 2023, 12:30 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

pw/

pw_group.c

3 lines

Diff 113621

View Options

pw: Don't return a pointer to an on-stack buffer from grp_set_passwd.ClosedPublicActions